third_party/WebKit/LayoutTests/media/video-controls-overlay-play-button.html - Issue 2015503002: Move TODO(philipj) to TODO(foolip)

Side by Side Diff

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Side by Side Diff: third_party/WebKit/LayoutTests/media/video-controls-overlay-play-button.html

Issue 2015503002: Move TODO(philipj) to TODO(foolip) (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: rebase Created 4 years, 7 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View unified diff | Download patch

« no previous file with comments | « third_party/WebKit/LayoutTests/media/video-controls-no-scripting.html ('k') | third_party/WebKit/LayoutTests/media/video-controls-show-on-focus.html » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

OLD	NEW
1 <!doctype html>	1 <!doctype html>

2 <html>	2 <html>

3 <head>	3 <head>

4 <title>Test that the overlay play button respects the controls attribute </title>	4 <title>Test that the overlay play button respects the controls attribute </title>

5 <script src="media-controls.js"></script>	5 <script src="media-controls.js"></script>

6 <script src="media-file.js"></script>	6 <script src="media-file.js"></script>

7 <!-- TODO(philipj): Convert test to testharness.js. crbug.com/588956	7 <!-- TODO(foolip): Convert test to testharness.js. crbug.com/588956

8 (Please avoid writing new tests using video-test.js) -->	8 (Please avoid writing new tests using video-test.js) -->

9 <script src="video-test.js"></script>	9 <script src="video-test.js"></script>

10 <script>	10 <script>

11 function start()	11 function start()

12 {	12 {

13 window.internals.settings.setMediaControlsOverlayPlayButtonEnabl ed(true);	13 window.internals.settings.setMediaControlsOverlayPlayButtonEnabl ed(true);

14	14

15 // Add element dynamically, since otherwise the controls are cre ated, but	15 // Add element dynamically, since otherwise the controls are cre ated, but

16 // hidden, before the setting is set, causing the setting to be ignored.	16 // hidden, before the setting is set, causing the setting to be ignored.

17 addVideoElement();	17 addVideoElement();

(...skipping 55 matching lines...) Expand 10 before \| Expand all \| Expand 10 after Loading...
73 testExpected('getComputedStyle(button).display', 'flex');	73 testExpected('getComputedStyle(button).display', 'flex');

74	74

75 endTest();	75 endTest();

76 }	76 }

77 </script>	77 </script>

78 </head>	78 </head>

79 <body onload="start()">	79 <body onload="start()">

80 <p>Test that the overlay play button respects the controls attribute</p>	80 <p>Test that the overlay play button respects the controls attribute</p>

81 </body>	81 </body>

82 </html>	82 </html>

OLD	NEW