third_party/WebKit/LayoutTests/media/video-append-source.html - Issue 2015503002: Move TODO(philipj) to TODO(foolip)

Side by Side Diff

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Side by Side Diff: third_party/WebKit/LayoutTests/media/video-append-source.html

Issue 2015503002: Move TODO(philipj) to TODO(foolip) (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: rebase Created 4 years, 6 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

OLD	NEW
1 <video controls></video>	1 <video controls></video>

2 <script src=media-file.js></script>	2 <script src=media-file.js></script>

3 <!-- TODO(philipj): Convert test to testharness.js. crbug.com/588956	3 <!-- TODO(foolip): Convert test to testharness.js. crbug.com/588956

4 (Please avoid writing new tests using video-test.js) -->	4 (Please avoid writing new tests using video-test.js) -->

5 <script src=video-test.js></script>	5 <script src=video-test.js></script>

6	6

7 <script>	7 <script>

8 testExpected("video.currentSrc", "");	8 testExpected("video.currentSrc", "");

9 var mediaFile = findMediaFile("video", "content/test");	9 var mediaFile = findMediaFile("video", "content/test");

10 var source = document.createElement("source");	10 var source = document.createElement("source");

11 source.setAttribute("src", mediaFile);	11 source.setAttribute("src", mediaFile);

12 video.appendChild(source);	12 video.appendChild(source);

13	13

14 testExpected("video.currentSrc", "");	14 testExpected("video.currentSrc", "");

15	15

16 waitForEvent("canplaythrough", function () {	16 waitForEvent("canplaythrough", function () {

17 testExpected("stripExtension(relativeURL(video.currentSrc))", stripExten sion(mediaFile));	17 testExpected("stripExtension(relativeURL(video.currentSrc))", stripExten sion(mediaFile));

18 endTest();	18 endTest();

19 });	19 });

20	20

21 </script>	21 </script>

OLD	NEW