third_party/WebKit/LayoutTests/media/track/track-word-breaking.html - Issue 2015503002: Move TODO(philipj) to TODO(foolip)

Side by Side Diff

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Side by Side Diff: third_party/WebKit/LayoutTests/media/track/track-word-breaking.html

Issue 2015503002: Move TODO(philipj) to TODO(foolip) (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: rebase Created 4 years, 7 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View unified diff | Download patch

« no previous file with comments | « third_party/WebKit/LayoutTests/media/track/track-webvtt-tc032-degenerate-cues.html ('k') | third_party/WebKit/LayoutTests/media/unsupported-rtsp.html » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

OLD	NEW
1 <html>	1 <html>

2 <head>	2 <head>

3 <script>	3 <script>

4 if (window.internals.settings)	4 if (window.internals.settings)

5 {	5 {

6 // This should not be necessary, but due to crbug.com/372245 style	6 // This should not be necessary, but due to crbug.com/372245 style

7 // gets dirtied during layout in LayoutTextTrackContainer which	7 // gets dirtied during layout in LayoutTextTrackContainer which

8 // causes assertions to fail when Document::scrollingElement is	8 // causes assertions to fail when Document::scrollingElement is

9 // queried during compositing update (a valid request).	9 // queried during compositing update (a valid request).

10 window.internals.settings.setCompositorWorkerEnabled(false);	10 window.internals.settings.setCompositorWorkerEnabled(false);

11 }	11 }

12 </script>	12 </script>

13 <script src=../media-file.js></script>	13 <script src=../media-file.js></script>

14 <!-- TODO(philipj): Convert test to testharness.js. crbug.com/588956	14 <!-- TODO(foolip): Convert test to testharness.js. crbug.com/588956

15 (Please avoid writing new tests using video-test.js) -->	15 (Please avoid writing new tests using video-test.js) -->

16 <script src=../video-test.js></script>	16 <script src=../video-test.js></script>

17 <script src=../media-controls.js></script>	17 <script src=../media-controls.js></script>

18 <script>	18 <script>

19	19

20 var singleLineRect;	20 var singleLineRect;

21	21

22 function testUnbreakableLine()	22 function testUnbreakableLine()

23 {	23 {

24 var multiLineRect = textTrackDisplayElement(video).firstChild.firstC hild.getBoundingClientRect();	24 var multiLineRect = textTrackDisplayElement(video).firstChild.firstC hild.getBoundingClientRect();

(...skipping 19 matching lines...) Expand all Loading...
44 }	44 }

45	45

46 </script>	46 </script>

47 </head>	47 </head>

48 <body onload="loaded()">	48 <body onload="loaded()">

49 <video controls >	49 <video controls >

50 <track src="captions-webvtt/long-word.vtt" kind="captions" default>	50 <track src="captions-webvtt/long-word.vtt" kind="captions" default>

51 </video>	51 </video>

52 </body>	52 </body>

53 </html>	53 </html>

OLD	NEW