third_party/WebKit/LayoutTests/media/track/track-webvtt-tc018-align-text-line-position.html - Issue 2015503002: Move TODO(philipj) to TODO(foolip)

Side by Side Diff

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Side by Side Diff: third_party/WebKit/LayoutTests/media/track/track-webvtt-tc018-align-text-line-position.html

Issue 2015503002: Move TODO(philipj) to TODO(foolip) (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: rebase Created 4 years, 7 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View unified diff | Download patch

« no previous file with comments | « third_party/WebKit/LayoutTests/media/track/track-webvtt-tc017-line-position.html ('k') | third_party/WebKit/LayoutTests/media/track/track-webvtt-tc019-cue-size.html » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

OLD	NEW
1 <!DOCTYPE html>	1 <!DOCTYPE html>

2 <html>	2 <html>

3 <head>	3 <head>

4 <meta http-equiv="Content-Type" content="text/html; charset=utf-8" />	4 <meta http-equiv="Content-Type" content="text/html; charset=utf-8" />

5	5

6 <script src=../media-file.js></script>	6 <script src=../media-file.js></script>

7 <!-- TODO(philipj): Convert test to testharness.js. crbug.com/588956	7 <!-- TODO(foolip): Convert test to testharness.js. crbug.com/588956

8 (Please avoid writing new tests using video-test.js) -->	8 (Please avoid writing new tests using video-test.js) -->

9 <script src=../video-test.js></script>	9 <script src=../video-test.js></script>

10 <script>	10 <script>

11	11

12 var numberOfTrackTests = 2;	12 var numberOfTrackTests = 2;

13	13

14 function trackLoaded()	14 function trackLoaded()

15 {	15 {

16 numberOfTracksLoaded++;	16 numberOfTracksLoaded++;

17 if (numberOfTracksLoaded == numberOfTrackTests) {	17 if (numberOfTracksLoaded == numberOfTrackTests) {

(...skipping 67 matching lines...) Expand 10 before \| Expand all \| Expand 10 after Loading...
85 </script>	85 </script>

86 </head>	86 </head>

87 <body onload="enableAllTextTracks()">	87 <body onload="enableAllTextTracks()">

88 <p>Tests cue alignment, line and text position from settings.</p>	88 <p>Tests cue alignment, line and text position from settings.</p>

89 <video>	89 <video>

90 <track src="captions-webvtt/tc018-align-text-line-position.vtt" onlo ad="trackLoaded()">	90 <track src="captions-webvtt/tc018-align-text-line-position.vtt" onlo ad="trackLoaded()">

91 <track src="captions-webvtt/tc018-align-text-line-position-bad.vtt" onload="trackLoaded()">	91 <track src="captions-webvtt/tc018-align-text-line-position-bad.vtt" onload="trackLoaded()">

92 </video>	92 </video>

93 </body>	93 </body>

94 </html>	94 </html>

OLD	NEW