third_party/WebKit/LayoutTests/media/track/track-webvtt-tc007-cue-no-id.html - Issue 2015503002: Move TODO(philipj) to TODO(foolip)

Side by Side Diff

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Side by Side Diff: third_party/WebKit/LayoutTests/media/track/track-webvtt-tc007-cue-no-id.html

Issue 2015503002: Move TODO(philipj) to TODO(foolip) (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: rebase Created 4 years, 6 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View unified diff | Download patch

« no previous file with comments | « third_party/WebKit/LayoutTests/media/track/track-webvtt-tc006-cue-identifiers.html ('k') | third_party/WebKit/LayoutTests/media/track/track-webvtt-tc011-blank-lines.html » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

OLD	NEW
1 <!DOCTYPE html>	1 <!DOCTYPE html>

2 <html>	2 <html>

3 <head>	3 <head>

4 <meta http-equiv="Content-Type" content="text/html; charset=utf-8" />	4 <meta http-equiv="Content-Type" content="text/html; charset=utf-8" />

5	5

6 <script src=../media-file.js></script>	6 <script src=../media-file.js></script>

7 <!-- TODO(philipj): Convert test to testharness.js. crbug.com/588956	7 <!-- TODO(foolip): Convert test to testharness.js. crbug.com/588956

8 (Please avoid writing new tests using video-test.js) -->	8 (Please avoid writing new tests using video-test.js) -->

9 <script src=../video-test.js></script>	9 <script src=../video-test.js></script>

10 <script>	10 <script>

11	11

12 numberOfTrackTests = 2;	12 numberOfTrackTests = 2;

13	13

14 function trackLoaded()	14 function trackLoaded()

15 {	15 {

16 numberOfTracksLoaded++;	16 numberOfTracksLoaded++;

17 if (numberOfTracksLoaded == numberOfTrackTests) {	17 if (numberOfTracksLoaded == numberOfTrackTests) {

(...skipping 50 matching lines...) Expand 10 before \| Expand all \| Expand 10 after Loading...
68 </script>	68 </script>

69 </head>	69 </head>

70 <body onload="enableAllTextTracks()">	70 <body onload="enableAllTextTracks()">

71 <p>Tests empty cue identifiers (they are optional), but makes sure "-->" found leads to discarded cue.</p>	71 <p>Tests empty cue identifiers (they are optional), but makes sure "-->" found leads to discarded cue.</p>

72 <video>	72 <video>

73 <track src="captions-webvtt/tc007-cue-no-id.vtt" onload="trackLoaded ()">	73 <track src="captions-webvtt/tc007-cue-no-id.vtt" onload="trackLoaded ()">

74 <track src="captions-webvtt/tc007-cue-no-id-error.vtt" onload="track Loaded()">	74 <track src="captions-webvtt/tc007-cue-no-id-error.vtt" onload="track Loaded()">

75 </video>	75 </video>

76 </body>	76 </body>

77 </html>	77 </html>

OLD	NEW