third_party/WebKit/LayoutTests/media/track/track-delete-during-setup.html - Issue 2015503002: Move TODO(philipj) to TODO(foolip)

Side by Side Diff

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Side by Side Diff: third_party/WebKit/LayoutTests/media/track/track-delete-during-setup.html

Issue 2015503002: Move TODO(philipj) to TODO(foolip) (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: rebase Created 4 years, 6 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View unified diff | Download patch

« no previous file with comments | « third_party/WebKit/LayoutTests/media/track/track-cues-sorted-before-dispatch.html ('k') | third_party/WebKit/LayoutTests/media/track/track-remove-quickly.html » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

OLD	NEW
1 >	1 >

2	2

3 <script>	3 <script>

4 if (window.internals)	4 if (window.internals)

5 {	5 {

6 // This should not be necessary, but due to crbug.com/372245 sty le	6 // This should not be necessary, but due to crbug.com/372245 sty le

7 // gets dirtied during layout in LayoutTextTrackContainer which	7 // gets dirtied during layout in LayoutTextTrackContainer which

8 // causes assertions to fail when Document::scrollingElement is	8 // causes assertions to fail when Document::scrollingElement is

9 // queried during compositing update (a valid request).	9 // queried during compositing update (a valid request).

10 window.internals.settings.setCompositorWorkerEnabled(false);	10 window.internals.settings.setCompositorWorkerEnabled(false);

11 }	11 }

12 </script>	12 </script>

13 <script src=../media-file.js></script>	13 <script src=../media-file.js></script>

14 <script></script>	14 <script></script>

15 <script></script>	15 <script></script>

16 <script>setTimeout("try { var v = document.querySelector('video'); v.parentNode. removeChild(v); } catch(e) {}", 61);</script>	16 <script>setTimeout("try { var v = document.querySelector('video'); v.parentNode. removeChild(v); } catch(e) {}", 61);</script>

17 <meta>	17 <meta>

18 <!-- TODO(philipj): Convert test to testharness.js. crbug.com/588956	18 <!-- TODO(foolip): Convert test to testharness.js. crbug.com/588956

19 (Please avoid writing new tests using video-test.js) -->	19 (Please avoid writing new tests using video-test.js) -->

20 <script src=../video-test.js></script>	20 <script src=../video-test.js></script>

21 <script>	21 <script>

22	22

23 {	23 {

24 }	24 }

25	25

26 function metadataTrackLoaded()	26 function metadataTrackLoaded()

27 {	27 {

28 track2 = document.createElement('track');	28 track2 = document.createElement('track');

(...skipping 16 matching lines...) Expand all Loading...
45 testExpected("track1.readyState", HTMLTrackElement.NONE);	45 testExpected("track1.readyState", HTMLTrackElement.NONE);

46 testExpected("track1.track.mode", "disabled");	46 testExpected("track1.track.mode", "disabled");

47	47

48 video.src = findMediaFile("video", "../content/test");	48 video.src = findMediaFile("video", "../content/test");

49 consoleWrite("");	49 consoleWrite("");

50 }	50 }

51 </script>	51 </script>

52 <body onload="start()">	52 <body onload="start()">

53 <command><aside><kbd><video oncanplaythrough="canplaythrough()" >	53 <command><aside><kbd><video oncanplaythrough="canplaythrough()" >

54 <track src="captions-webvtt/metadata.vtt" onload="metadataTrackLoade d()">	54 <track src="captions-webvtt/metadata.vtt" onload="metadataTrackLoade d()">

OLD	NEW