third_party/WebKit/LayoutTests/media/track/track-cue-rendering-horizontal.html - Issue 2015503002: Move TODO(philipj) to TODO(foolip)

Side by Side Diff

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Side by Side Diff: third_party/WebKit/LayoutTests/media/track/track-cue-rendering-horizontal.html

Issue 2015503002: Move TODO(philipj) to TODO(foolip) (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: rebase Created 4 years, 6 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View unified diff | Download patch

« no previous file with comments | « third_party/WebKit/LayoutTests/media/track/track-cue-gc-wrapper.html ('k') | third_party/WebKit/LayoutTests/media/track/track-cue-rendering-vertical.html » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

OLD	NEW
1 <!DOCTYPE html>	1 <!DOCTYPE html>

2 <html>	2 <html>

3 <head>	3 <head>

4 <meta http-equiv="Content-Type" content="text/html; charset=utf-8" />	4 <meta http-equiv="Content-Type" content="text/html; charset=utf-8" />

5	5

6 <script src=../media-file.js></script>	6 <script src=../media-file.js></script>

7	7

8 <script>	8 <script>

9 var requirePixelDump = true;	9 var requirePixelDump = true;

10	10

11 function loaded()	11 function loaded()

12 {	12 {

13 consoleWrite("Rendering horizontal line-positioned cues.");	13 consoleWrite("Rendering horizontal line-positioned cues.");

14 findMediaElement();	14 findMediaElement();

15	15

16 testTrack = document.querySelector('track');	16 testTrack = document.querySelector('track');

17 video.src = findMediaFile('video', '../content/test');	17 video.src = findMediaFile('video', '../content/test');

18	18

19 waitForEvent('seeked', endTest);	19 waitForEvent('seeked', endTest);

20 waitForEvent('canplaythrough', function() {	20 waitForEvent('canplaythrough', function() {

21 video.currentTime = .25;	21 video.currentTime = .25;

22 });	22 });

23 }	23 }

24	24

25 </script>	25 </script>

26	26

27 <!-- TODO(philipj): Convert test to testharness.js. crbug.com/588956	27 <!-- TODO(foolip): Convert test to testharness.js. crbug.com/588956

28 (Please avoid writing new tests using video-test.js) -->	28 (Please avoid writing new tests using video-test.js) -->

29 <script src=../video-test.js></script>	29 <script src=../video-test.js></script>

30 </head>	30 </head>

31 <body onload="loaded()">	31 <body onload="loaded()">

32 <video>	32 <video>

33 <track src="captions-webvtt/captions-snap-to-lines-set.vtt" kind="ca ptions" default>	33 <track src="captions-webvtt/captions-snap-to-lines-set.vtt" kind="ca ptions" default>

34 </video>	34 </video>

35 </body>	35 </body>

36 </html>	36 </html>

OLD	NEW