third_party/WebKit/LayoutTests/media/media-captions-no-controls.html - Issue 2015503002: Move TODO(philipj) to TODO(foolip)

Side by Side Diff

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Side by Side Diff: third_party/WebKit/LayoutTests/media/media-captions-no-controls.html

Issue 2015503002: Move TODO(philipj) to TODO(foolip) (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: rebase Created 4 years, 6 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View unified diff | Download patch

« no previous file with comments | « third_party/WebKit/LayoutTests/media/media-can-play-webm.html ('k') | third_party/WebKit/LayoutTests/media/media-constants.html » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

OLD	NEW
1 <!DOCTYPE html>	1 <!DOCTYPE html>

2 <html>	2 <html>

3 <head>	3 <head>

4 <meta http-equiv="Content-Type" content="text/html; charset=utf-8" />	4 <meta http-equiv="Content-Type" content="text/html; charset=utf-8" />

5	5

6 <script src=media-file.js></script>	6 <script src=media-file.js></script>

7 <!-- TODO(philipj): Convert test to testharness.js. crbug.com/588956	7 <!-- TODO(foolip): Convert test to testharness.js. crbug.com/588956

8 (Please avoid writing new tests using video-test.js) -->	8 (Please avoid writing new tests using video-test.js) -->

9 <script src=video-test.js></script>	9 <script src=video-test.js></script>

10 <script src=media-controls.js></script>	10 <script src=media-controls.js></script>

11 <script>	11 <script>

12	12

13 function canplaythrough()	13 function canplaythrough()

14 {	14 {

15 consoleWrite("<br> Initial state: no text tracks, controls sho uld not be visible ");	15 consoleWrite("<br> Initial state: no text tracks, controls sho uld not be visible ");

16 testExpected("video.textTracks.length", 0);	16 testExpected("video.textTracks.length", 0);

17 testExpected("video.controls", false, '==');	17 testExpected("video.controls", false, '==');

(...skipping 24 matching lines...) Expand all Loading...
42 }	42 }

43	43

44 </script>	44 </script>

45 </head>	45 </head>

46 <body onload="start()">	46 <body onload="start()">

47 <video>	47 <video>

48 </video>	48 </video>

49 <p>Tests that adding a text track does not make controls visible.</p>	49 <p>Tests that adding a text track does not make controls visible.</p>

50 </body>	50 </body>

51 </html>	51 </html>

OLD	NEW