third_party/WebKit/LayoutTests/media/invalid-media-url-crash.html - Issue 2015503002: Move TODO(philipj) to TODO(foolip)

Side by Side Diff

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Side by Side Diff: third_party/WebKit/LayoutTests/media/invalid-media-url-crash.html

Issue 2015503002: Move TODO(philipj) to TODO(foolip) (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: rebase Created 4 years, 6 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

OLD	NEW
1 <html>	1 <html>

2 <body>	2 <body>

3 <p>Tests that invalid media src url does not result in crash.</p>	3 <p>Tests that invalid media src url does not result in crash.</p>

4 <!-- TODO(philipj): Convert test to testharness.js. crbug.com/588956	4 <!-- TODO(foolip): Convert test to testharness.js. crbug.com/588956

5 (Please avoid writing new tests using video-test.js) -->	5 (Please avoid writing new tests using video-test.js) -->

6 <script src=video-test.js></script>	6 <script src=video-test.js></script>

7 <script>	7 <script>

8 var invalid_url = "!:/" + String.fromCharCode(0) + "%aa#aa";	8 var invalid_url = "!:/" + String.fromCharCode(0) + "%aa#aa";

9 var error_count = 0;	9 var error_count = 0;

10	10

11 function errorEvent()	11 function errorEvent()

12 {	12 {

13 error_count++;	13 error_count++;

14 if (error_count == 2)	14 if (error_count == 2)

(...skipping 10 matching lines...) Expand all Loading...
25 var video = document.createElement('video');	25 var video = document.createElement('video');

26 audio.src = invalid_url;	26 audio.src = invalid_url;

27 video.src = invalid_url;	27 video.src = invalid_url;

28 audio.onerror = errorEvent;	28 audio.onerror = errorEvent;

29 video.onerror = errorEvent;	29 video.onerror = errorEvent;

30 document.body.appendChild(audio);	30 document.body.appendChild(audio);

31 document.body.appendChild(video);	31 document.body.appendChild(video);

32 </script>	32 </script>

33 </body>	33 </body>

34 </html>	34 </html>

OLD	NEW