third_party/WebKit/LayoutTests/media/controls-volume-slider.html - Issue 2015503002: Move TODO(philipj) to TODO(foolip)

Side by Side Diff

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Side by Side Diff: third_party/WebKit/LayoutTests/media/controls-volume-slider.html

Issue 2015503002: Move TODO(philipj) to TODO(foolip) (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: rebase Created 4 years, 6 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View unified diff | Download patch

« no previous file with comments | « third_party/WebKit/LayoutTests/media/controls-timeline.html ('k') | third_party/WebKit/LayoutTests/media/controls-volume-slider-keynav.html » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

OLD	NEW
1 <!doctype html>	1 <!doctype html>

2 <html>	2 <html>

3 <head>	3 <head>

4 <title>media controls volume slider</title>	4 <title>media controls volume slider</title>

5 <script src="media-file.js"></script>	5 <script src="media-file.js"></script>

6 <script src="media-controls.js"></script>	6 <script src="media-controls.js"></script>

7 <!-- TODO(philipj): Convert test to testharness.js. crbug.com/588956	7 <!-- TODO(foolip): Convert test to testharness.js. crbug.com/588956

8 (Please avoid writing new tests using video-test.js) -->	8 (Please avoid writing new tests using video-test.js) -->

9 <script src="video-test.js"></script>	9 <script src="video-test.js"></script>

10 </head>	10 </head>

11 <body>	11 <body>

12 <audio controls></audio>	12 <audio controls></audio>

13 <script>	13 <script>

14 findMediaElement();	14 findMediaElement();

15 audio.src = findMediaFile("audio", "content/test");	15 audio.src = findMediaFile("audio", "content/test");

16 testExpected("audio.volume", 1);	16 testExpected("audio.volume", 1);

17 waitForEvent("loadedmetadata", function()	17 waitForEvent("loadedmetadata", function()

18 {	18 {

19 // click the middle of the volume slider	19 // click the middle of the volume slider

20 var coords = mediaControlsButtonCoordinates(audio, "volume-slide r");	20 var coords = mediaControlsButtonCoordinates(audio, "volume-slide r");

21 eventSender.mouseMoveTo(coords[0], coords[1]);	21 eventSender.mouseMoveTo(coords[0], coords[1]);

22 eventSender.mouseDown();	22 eventSender.mouseDown();

23 eventSender.mouseMoveTo(coords[0]-1, coords[1]);	23 eventSender.mouseMoveTo(coords[0]-1, coords[1]);

24 eventSender.mouseMoveTo(coords[0], coords[1]);	24 eventSender.mouseMoveTo(coords[0], coords[1]);

25 eventSender.mouseUp();	25 eventSender.mouseUp();

26	26

27 testExpected("audio.volume", 0.4, '>');	27 testExpected("audio.volume", 0.4, '>');

28 testExpected("audio.volume", 0.6, '<');	28 testExpected("audio.volume", 0.6, '<');

29 waitForEventAndEnd("volumechange");	29 waitForEventAndEnd("volumechange");

30 });	30 });

31 </script>	31 </script>

32 </body>	32 </body>

33 </html>	33 </html>

OLD	NEW