third_party/WebKit/LayoutTests/media/controls-timeline.html - Issue 2015503002: Move TODO(philipj) to TODO(foolip)

Side by Side Diff

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Side by Side Diff: third_party/WebKit/LayoutTests/media/controls-timeline.html

Issue 2015503002: Move TODO(philipj) to TODO(foolip) (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: rebase Created 4 years, 7 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View unified diff | Download patch

« no previous file with comments | « third_party/WebKit/LayoutTests/media/controls-right-click-on-timebar.html ('k') | third_party/WebKit/LayoutTests/media/controls-volume-slider.html » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

OLD	NEW
1 <!doctype html>	1 <!doctype html>

2 <html>	2 <html>

3 <head>	3 <head>

4 <title>media controls timeline</title>	4 <title>media controls timeline</title>

5 <script src="media-file.js"></script>	5 <script src="media-file.js"></script>

6 <script src="media-controls.js"></script>	6 <script src="media-controls.js"></script>

7 <!-- TODO(philipj): Convert test to testharness.js. crbug.com/588956	7 <!-- TODO(foolip): Convert test to testharness.js. crbug.com/588956

8 (Please avoid writing new tests using video-test.js) -->	8 (Please avoid writing new tests using video-test.js) -->

9 <script src="video-test.js"></script>	9 <script src="video-test.js"></script>

10 </head>	10 </head>

11 <body>	11 <body>

12 <video controls></video>	12 <video controls></video>

13 <script>	13 <script>

14 findMediaElement();	14 findMediaElement();

15 video.src = findMediaFile("video", "content/test");	15 video.src = findMediaFile("video", "content/test");

16 waitForEvent("loadedmetadata", function()	16 waitForEvent("loadedmetadata", function()

17 {	17 {

18 testExpected("video.currentTime", 0);	18 testExpected("video.currentTime", 0);

19 testExpected("video.seeking", false);	19 testExpected("video.seeking", false);

20	20

21 // click the middle of the timeline	21 // click the middle of the timeline

22 var coords = mediaControlsButtonCoordinates(video, "timeline");	22 var coords = mediaControlsButtonCoordinates(video, "timeline");

23 eventSender.mouseMoveTo(coords[0], coords[1]);	23 eventSender.mouseMoveTo(coords[0], coords[1]);

24 eventSender.mouseDown();	24 eventSender.mouseDown();

25 eventSender.mouseUp();	25 eventSender.mouseUp();

26	26

27 testExpected("video.currentTime / video.duration", 0.4, '>');	27 testExpected("video.currentTime / video.duration", 0.4, '>');

28 testExpected("video.currentTime / video.duration", 0.6, '<');	28 testExpected("video.currentTime / video.duration", 0.6, '<');

29 testExpected("video.seeking", true);	29 testExpected("video.seeking", true);

30	30

31 endTest();	31 endTest();

32 });	32 });

33 </script>	33 </script>

34 </body>	34 </body>

35 </html>	35 </html>

OLD	NEW