third_party/WebKit/LayoutTests/media/controls-css-overload.html - Issue 2015503002: Move TODO(philipj) to TODO(foolip)

Side by Side Diff

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Side by Side Diff: third_party/WebKit/LayoutTests/media/controls-css-overload.html

Issue 2015503002: Move TODO(philipj) to TODO(foolip) (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: rebase Created 4 years, 6 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View unified diff | Download patch

« no previous file with comments | « third_party/WebKit/LayoutTests/media/controls-cast-overlay-slow-fade.html ('k') | third_party/WebKit/LayoutTests/media/controls-drag-timebar.html » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

OLD	NEW
1 <!DOCTYPE html PUBLIC "-//W3C//DTD HTML 4.01//EN"	1 <!DOCTYPE html PUBLIC "-//W3C//DTD HTML 4.01//EN"

2 "http://www.w3.org/TR/html4/strict.dtd">	2 "http://www.w3.org/TR/html4/strict.dtd">

3	3

4 <html>	4 <html>

5 <head>	5 <head>

6 <title>Testing that overloading some controls doesn't crash the browser</tit le>	6 <title>Testing that overloading some controls doesn't crash the browser</tit le>

7 <style>	7 <style>

8 .nocontrols::-webkit-media-controls-panel{	8 .nocontrols::-webkit-media-controls-panel{

9 display:none;	9 display:none;

10 }	10 }

11 .notimeline::-webkit-media-controls-timeline-container{	11 .notimeline::-webkit-media-controls-timeline-container{

12 display:none;	12 display:none;

13 }	13 }

14 </style>	14 </style>

15 <!-- TODO(philipj): Convert test to testharness.js. crbug.com/588956	15 <!-- TODO(foolip): Convert test to testharness.js. crbug.com/588956

16 (Please avoid writing new tests using video-test.js) -->	16 (Please avoid writing new tests using video-test.js) -->

17 <script src=video-test.js></script>	17 <script src=video-test.js></script>

18 </head>	18 </head>

19 <body>	19 <body>

20 <video class="nocontrols" width=300 height=200 controls></video>	20 <video class="nocontrols" width=300 height=200 controls></video>

21 <video class="notimeline" width=300 height=200 controls></video>	21 <video class="notimeline" width=300 height=200 controls></video>

22 <script>	22 <script>

23 consoleWrite("I did not crash");	23 consoleWrite("I did not crash");

24 endTest();	24 endTest();

25 </script>	25 </script>

26 </body>	26 </body>

27 </html>	27 </html>

OLD	NEW