third_party/WebKit/LayoutTests/media/controls-cast-overlay-slow-fade.html - Issue 2015503002: Move TODO(philipj) to TODO(foolip)

Side by Side Diff

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Side by Side Diff: third_party/WebKit/LayoutTests/media/controls-cast-overlay-slow-fade.html

Issue 2015503002: Move TODO(philipj) to TODO(foolip) (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: rebase Created 4 years, 7 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View unified diff | Download patch

« no previous file with comments | « third_party/WebKit/LayoutTests/media/controls-cast-do-not-fade-out.html ('k') | third_party/WebKit/LayoutTests/media/controls-css-overload.html » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

OLD	NEW
1 <!doctype html>	1 <!doctype html>

2 <html>	2 <html>

3 <head>	3 <head>

4 <title>Test that the overlay cast button fades at the right time (neithe r too soon nor too late).</title>	4 <title>Test that the overlay cast button fades at the right time (neithe r too soon nor too late).</title>

5 <script src="../resources/testharness.js"></script>	5 <script src="../resources/testharness.js"></script>

6 <script src="../resources/testharnessreport.js"></script>	6 <script src="../resources/testharnessreport.js"></script>

7 <script src="media-file.js"></script>	7 <script src="media-file.js"></script>

8 <script src="media-controls.js"></script>	8 <script src="media-controls.js"></script>

9 <!-- TODO(philipj): Convert test to testharness.js. crbug.com/588956	9 <!-- TODO(foolip): Convert test to testharness.js. crbug.com/588956

10 (Please avoid writing new tests using video-test.js) -->	10 (Please avoid writing new tests using video-test.js) -->

11 <script src="video-test.js"></script>	11 <script src="video-test.js"></script>

12 </head>	12 </head>

13 <body>	13 <body>

14 <video loop></video>	14 <video loop></video>

15 <script>	15 <script>

16 var controls;	16 var controls;

17 var test;	17 var test;

18 // The cast button should be visible for at least the controlsMouseMovem entTimeout, and no more	18 // The cast button should be visible for at least the controlsMouseMovem entTimeout, and no more

19 // than that plus the fadeout time. Allow 500ms margin at either side.	19 // than that plus the fadeout time. Allow 500ms margin at either side.

(...skipping 32 matching lines...) Expand 10 before \| Expand all \| Expand 10 after Loading...
52 "button should not exist, display = \"" + display + '\"');	52 "button should not exist, display = \"" + display + '\"');

53 t.done();	53 t.done();

54 }), hideTimeoutUpperBound);	54 }), hideTimeoutUpperBound);

55 }));	55 }));

56 internals.mediaPlayerRemoteRouteAvailabilityChanged(video, true);	56 internals.mediaPlayerRemoteRouteAvailabilityChanged(video, true);

57 video.play();	57 video.play();

58 });	58 });

59 </script>	59 </script>

60 </body>	60 </body>

61 </html>	61 </html>

OLD	NEW