third_party/WebKit/LayoutTests/media/controls-cast-button.html - Issue 2015503002: Move TODO(philipj) to TODO(foolip)

Side by Side Diff

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Side by Side Diff: third_party/WebKit/LayoutTests/media/controls-cast-button.html

Issue 2015503002: Move TODO(philipj) to TODO(foolip) (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: rebase Created 4 years, 7 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View unified diff | Download patch

« no previous file with comments | « third_party/WebKit/LayoutTests/media/constructors.html ('k') | third_party/WebKit/LayoutTests/media/controls-cast-button-narrow.html » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

OLD	NEW
1 <!doctype html>	1 <!doctype html>

2 <html>	2 <html>

3 <head>	3 <head>

4 <title>media controls cast button</title>	4 <title>media controls cast button</title>

5 <script src="../resources/testharness.js"></script>	5 <script src="../resources/testharness.js"></script>

6 <script src="../resources/testharnessreport.js"></script>	6 <script src="../resources/testharnessreport.js"></script>

7 <script src="media-file.js"></script>	7 <script src="media-file.js"></script>

8 <script src="media-controls.js"></script>	8 <script src="media-controls.js"></script>

9 <!-- TODO(philipj): Convert test to testharness.js. crbug.com/588956	9 <!-- TODO(foolip): Convert test to testharness.js. crbug.com/588956

10 (Please avoid writing new tests using video-test.js) -->	10 (Please avoid writing new tests using video-test.js) -->

11 <script src="video-test.js"></script>	11 <script src="video-test.js"></script>

12 </head>	12 </head>

13 <body>	13 <body>

14 <video controls width=500></video>	14 <video controls width=500></video>

15 <script>	15 <script>

16 function castButton(element)	16 function castButton(element)

17 {	17 {

18 var controlID = "-internal-media-controls-cast-button";	18 var controlID = "-internal-media-controls-cast-button";

19 var button = mediaControlsElement(window.internals.shadowRoot(elemen t).firstChild, controlID);	19 var button = mediaControlsElement(window.internals.shadowRoot(elemen t).firstChild, controlID);

(...skipping 58 matching lines...) Expand 10 before \| Expand all \| Expand 10 after Loading...
78	78

79 // Remove cast device - cast button should go away	79 // Remove cast device - cast button should go away

80 internals.mediaPlayerRemoteRouteAvailabilityChanged(video, false );	80 internals.mediaPlayerRemoteRouteAvailabilityChanged(video, false );

81 assert_equals(button.style.display, "none", "button should not b e visible after cast device goes away");	81 assert_equals(button.style.display, "none", "button should not b e visible after cast device goes away");

82 t.done();	82 t.done();

83 });	83 });

84 });	84 });

85 </script>	85 </script>

86 </body>	86 </body>

87 </html>	87 </html>

OLD	NEW