Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1564)

Issues Search
    My Issues | Starred     Open | Closed | All

Side by Side Diff: third_party/WebKit/LayoutTests/media/audio-garbage-collect.html

Issue 2015503002: Move TODO(philipj) to TODO(foolip) (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: rebase Created 4 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « third_party/WebKit/LayoutTests/media/audio-delete-while-slider-thumb-clicked.html ('k') | third_party/WebKit/LayoutTests/media/audio-play-event.html » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 <!DOCTYPE HTML> 1 <!DOCTYPE HTML>
2 2
3 <html> 3 <html>
4 <body> 4 <body>
5 5
6 <p>Tests that we don't garbage collect playing audio object or event listener.</ p> 6 <p>Tests that we don't garbage collect playing audio object or event listener.</ p>
7 <p>According to http://www.whatwg.org/specs/web-apps/current-work/multipage/the- video-element.html,<br /> 7 <p>According to http://www.whatwg.org/specs/web-apps/current-work/multipage/the- video-element.html,<br />
8 "4.8.10.8 Playing the media resource",<br /> 8 "4.8.10.8 Playing the media resource",<br />
9 "Media elements must not stop playing just because all references to them have 9 "Media elements must not stop playing just because all references to them have
10 been removed; only once a media element is in a state where no further audio 10 been removed; only once a media element is in a state where no further audio
11 could ever be played by that element may the element be garbage collected."<br / ><br /> 11 could ever be played by that element may the element be garbage collected."<br / ><br />
12 (see https://bugs.webkit.org/show_bug.cgi?id=66878, https://bugs.webkit.org/show _bug.cgi?id=70421, and http://crbug.com/62604 for more details).</p> 12 (see https://bugs.webkit.org/show_bug.cgi?id=66878, https://bugs.webkit.org/show _bug.cgi?id=70421, and http://crbug.com/62604 for more details).</p>
13 <p id="result"> 13 <p id="result">
14 FAIL: Test either still running or stopped prematurely. 14 FAIL: Test either still running or stopped prematurely.
15 </p> 15 </p>
16 16
17 <script src=../resources/gc.js></script> 17 <script src=../resources/gc.js></script>
18 <script src=media-file.js></script> 18 <script src=media-file.js></script>
19 <!-- TODO(philipj): Convert test to testharness.js. crbug.com/588956 19 <!-- TODO(foolip): Convert test to testharness.js. crbug.com/588956
20 (Please avoid writing new tests using video-test.js) --> 20 (Please avoid writing new tests using video-test.js) -->
21 <script src=video-test.js></script> 21 <script src=video-test.js></script>
22 <script type="text/javascript"> 22 <script type="text/javascript">
23 23
24 var num_players = 4; 24 var num_players = 4;
25 var play_times = 5; 25 var play_times = 5;
26 26
27 function finish() { 27 function finish() {
28 document.getElementById("result").innerText = "PASS"; 28 document.getElementById("result").innerText = "PASS";
29 if (window.testRunner) { 29 if (window.testRunner) {
(...skipping 27 matching lines...) Expand all
57 a.currentTime = a.duration - 0.35; 57 a.currentTime = a.duration - 0.35;
58 a.play(); 58 a.play();
59 }, false, true, a, true); 59 }, false, true, a, true);
60 } 60 }
61 61
62 start(); 62 start();
63 63
64 </script> 64 </script>
65 </body> 65 </body>
66 </html> 66 </html>
OLDNEW
« no previous file with comments | « third_party/WebKit/LayoutTests/media/audio-delete-while-slider-thumb-clicked.html ('k') | third_party/WebKit/LayoutTests/media/audio-play-event.html » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698