third_party/WebKit/LayoutTests/media/audio-controls-captions.html - Issue 2015503002: Move TODO(philipj) to TODO(foolip)

Side by Side Diff

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Side by Side Diff: third_party/WebKit/LayoutTests/media/audio-controls-captions.html

Issue 2015503002: Move TODO(philipj) to TODO(foolip) (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: rebase Created 4 years, 6 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View unified diff | Download patch

« no previous file with comments | « third_party/WebKit/LayoutTests/media/audio-concurrent-supported.html ('k') | third_party/WebKit/LayoutTests/media/audio-controls-do-not-fade-out.html » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

OLD	NEW
1 <!DOCTYPE html>	1 <!DOCTYPE html>

2 <html>	2 <html>

3 <head>	3 <head>

4 <meta http-equiv="Content-Type" content="text/html; charset=utf-8" />	4 <meta http-equiv="Content-Type" content="text/html; charset=utf-8" />

5 <title>Test closed caption button visbility.</title>	5 <title>Test closed caption button visbility.</title>

6 <script src=media-file.js></script>	6 <script src=media-file.js></script>

7 <script src=media-controls.js></script>	7 <script src=media-controls.js></script>

8 <!-- TODO(philipj): Convert test to testharness.js. crbug.com/588956	8 <!-- TODO(foolip): Convert test to testharness.js. crbug.com/588956

9 (Please avoid writing new tests using video-test.js) -->	9 (Please avoid writing new tests using video-test.js) -->

10 <script src=video-test.js></script>	10 <script src=video-test.js></script>

11 </head>	11 </head>

12 <body>	12 <body>

13 <p>Tests that the closed captions button is not visible.</p>	13 <p>Tests that the closed captions button is not visible.</p>

14 <audio controls>	14 <audio controls>

15 <track src="track/captions-webvtt/captions-fast.vtt">	15 <track src="track/captions-webvtt/captions-fast.vtt">

16 </audio>	16 </audio>

17 <script>	17 <script>

18 findMediaElement();	18 findMediaElement();

19 audio.src = findMediaFile('audio', 'content/test');	19 audio.src = findMediaFile('audio', 'content/test');

20 audio.addEventListener('loadedmetadata', function()	20 audio.addEventListener('loadedmetadata', function()

21 {	21 {

22 testClosedCaptionsButtonVisibility(false);	22 testClosedCaptionsButtonVisibility(false);

23 endTest();	23 endTest();

24 });	24 });

25 </script>	25 </script>

26 </body>	26 </body>

27 </html>	27 </html>

OLD	NEW