third_party/WebKit/LayoutTests/http/tests/security/video-cross-origin-via-dom.html - Issue 2015503002: Move TODO(philipj) to TODO(foolip)

Side by Side Diff

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Side by Side Diff: third_party/WebKit/LayoutTests/http/tests/security/video-cross-origin-via-dom.html

Issue 2015503002: Move TODO(philipj) to TODO(foolip) (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: rebase Created 4 years, 6 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View unified diff | Download patch

« no previous file with comments | « third_party/WebKit/LayoutTests/http/tests/security/video-cross-origin-readback.html ('k') | third_party/WebKit/LayoutTests/media/audio-autoplay-experiment-modes.html » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

OLD	NEW
1 <!doctype html>	1 <!doctype html>

2 <html>	2 <html>

3 <body onload="start()">	3 <body onload="start()">

4 <!-- TODO(philipj): Convert test to testharness.js. crbug.com/588956	4 <!-- TODO(foolip): Convert test to testharness.js. crbug.com/588956

5 (Please avoid writing new tests using video-test.js) -->	5 (Please avoid writing new tests using video-test.js) -->

6 <script src=../../media-resources/video-test.js></script>	6 <script src=../../media-resources/video-test.js></script>

7 <script src=../../media-resources/media-file.js></script>	7 <script src=../../media-resources/media-file.js></script>

8 <script>	8 <script>

9 waitForEvent('error', function() {	9 waitForEvent('error', function() {

10 failTest("error: " + JSON.stringify(video.error));	10 failTest("error: " + JSON.stringify(video.error));

11 });	11 });

12	12

13 waitForEvent('playing', function() {	13 waitForEvent('playing', function() {

14 try {	14 try {

(...skipping 12 matching lines...) Expand all Loading...
27 document.body.appendChild(mediaElement);	27 document.body.appendChild(mediaElement);

28 var mediaFile = findMediaFile("video", "../../media/resources/test") ;	28 var mediaFile = findMediaFile("video", "../../media/resources/test") ;

29 var type = mimeTypeForExtension(mediaFile.split('.').pop());	29 var type = mimeTypeForExtension(mediaFile.split('.').pop());

30 video.src = "http://localhost:8080/security/resources/video-cross-or igin-allow.php?no-preflight&name=" + mediaFile + "&type=" + type;	30 video.src = "http://localhost:8080/security/resources/video-cross-or igin-allow.php?no-preflight&name=" + mediaFile + "&type=" + type;

31 video.play();	31 video.play();

32 }	32 }

33 </script>	33 </script>

34 <canvas></canvas>	34 <canvas></canvas>

35 </body>	35 </body>

36 </head>	36 </head>

OLD	NEW