third_party/WebKit/LayoutTests/http/tests/media/video-in-iframe-crash.html - Issue 2015503002: Move TODO(philipj) to TODO(foolip)

Side by Side Diff

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Side by Side Diff: third_party/WebKit/LayoutTests/http/tests/media/video-in-iframe-crash.html

Issue 2015503002: Move TODO(philipj) to TODO(foolip) (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: rebase Created 4 years, 6 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

OLD	NEW
1 <!doctype html>	1 <!doctype html>

2 <html>	2 <html>

3 <!-- TODO(philipj): Convert test to testharness.js. crbug.com/588956	3 <!-- TODO(foolip): Convert test to testharness.js. crbug.com/588956

4 (Please avoid writing new tests using video-test.js) -->	4 (Please avoid writing new tests using video-test.js) -->

5 <script src="../../media-resources/video-test.js"></script>	5 <script src="../../media-resources/video-test.js"></script>

6 <script>	6 <script>

7 function getNextURL()	7 function getNextURL()

8 {	8 {

9 var url = location.href;	9 var url = location.href;

10 var queryIndex = url.indexOf("?");	10 var queryIndex = url.indexOf("?");

11 var loadCount = 1;	11 var loadCount = 1;

12 if (queryIndex >= 0) {	12 if (queryIndex >= 0) {

13 loadCount = parseInt(url.substring(queryIndex + 1));	13 loadCount = parseInt(url.substring(queryIndex + 1));

(...skipping 41 matching lines...) Expand 10 before \| Expand all \| Expand 10 after Loading...
55 document.body.appendChild(iframeContentDocument.firstChild);	55 document.body.appendChild(iframeContentDocument.firstChild);

56 reloadPage();	56 reloadPage();

57 }	57 }

58	58

59 </script>	59 </script>

60 <body onload="start()">	60 <body onload="start()">

61 <p>Tests that moving a <video> in and out of an iframe does not tr igger a crash.</p>	61 <p>Tests that moving a <video> in and out of an iframe does not tr igger a crash.</p>

62 <div id="store_div"></div>	62 <div id="store_div"></div>

63 </body>	63 </body>

64 </html>	64 </html>

OLD	NEW