third_party/WebKit/LayoutTests/http/tests/media/reload-after-dialog.html - Issue 2015503002: Move TODO(philipj) to TODO(foolip)

Side by Side Diff

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Side by Side Diff: third_party/WebKit/LayoutTests/http/tests/media/reload-after-dialog.html

Issue 2015503002: Move TODO(philipj) to TODO(foolip) (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: rebase Created 4 years, 6 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View unified diff | Download patch

« no previous file with comments | « third_party/WebKit/LayoutTests/http/tests/media/progress-events-generated-correctly.html ('k') | third_party/WebKit/LayoutTests/http/tests/media/remove-while-loading.html » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

OLD	NEW
1 <!DOCTYPE html>	1 <!DOCTYPE html>

2 <html>	2 <html>

3 <head>	3 <head>

4 <script src=../../media-resources/media-file.js></script>	4 <script src=../../media-resources/media-file.js></script>

5 <!-- TODO(philipj): Convert test to testharness.js. crbug.com/588956	5 <!-- TODO(foolip): Convert test to testharness.js. crbug.com/588956

6 (Please avoid writing new tests using video-test.js) -->	6 (Please avoid writing new tests using video-test.js) -->

7 <script src=../../media-resources/video-test.js></script>	7 <script src=../../media-resources/video-test.js></script>

8 <script>	8 <script>

9 var loadCount = 0;	9 var loadCount = 0;

10	10

11 if (window.testRunner) {	11 if (window.testRunner) {

12 testRunner.dumpAsText();	12 testRunner.dumpAsText();

13 testRunner.waitUntilDone();	13 testRunner.waitUntilDone();

14 }	14 }

15	15

(...skipping 41 matching lines...) Expand 10 before \| Expand all \| Expand 10 after Loading...
57 <video controls	57 <video controls

58 oncanplaythrough="canplaythrough()"	58 oncanplaythrough="canplaythrough()"

59 onloadstart="loadstart()">	59 onloadstart="loadstart()">

60 </video>	60 </video>

61 <p>Make sure we don't reload a <video> element after a dialog is s hown.<br>	61 <p>Make sure we don't reload a <video> element after a dialog is s hown.<br>

62 Test this by loading a movie slowly and showing a dialog when a 'loadsta rt' event <br>	62 Test this by loading a movie slowly and showing a dialog when a 'loadsta rt' event <br>

63 handler is called. If the movie is reloaded when the dialog is "dismisse d", another <br>	63 handler is called. If the movie is reloaded when the dialog is "dismisse d", another <br>

64 'loadstart' event will be fired</p>	64 'loadstart' event will be fired</p>

65 </body>	65 </body>

66 </html>	66 </html>

OLD	NEW