third_party/WebKit/LayoutTests/http/tests/media/progress-events-generated-correctly.html - Issue 2015503002: Move TODO(philipj) to TODO(foolip)

Side by Side Diff

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Side by Side Diff: third_party/WebKit/LayoutTests/http/tests/media/progress-events-generated-correctly.html

Issue 2015503002: Move TODO(philipj) to TODO(foolip) (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: rebase Created 4 years, 6 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View unified diff | Download patch

« no previous file with comments | « third_party/WebKit/LayoutTests/http/tests/media/pdf-served-as-pdf.html ('k') | third_party/WebKit/LayoutTests/http/tests/media/reload-after-dialog.html » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

OLD	NEW
1 <video controls></video>	1 <video controls></video>

2 <p>Test that progress events are generated during loading of media resource.</p>	2 <p>Test that progress events are generated during loading of media resource.</p>

3 <!-- TODO(philipj): Convert test to testharness.js. crbug.com/588956	3 <!-- TODO(foolip): Convert test to testharness.js. crbug.com/588956

4 (Please avoid writing new tests using video-test.js) -->	4 (Please avoid writing new tests using video-test.js) -->

5 <script src=../../media-resources/video-test.js></script>	5 <script src=../../media-resources/video-test.js></script>

6 <script src=../../media-resources/media-file.js></script>	6 <script src=../../media-resources/media-file.js></script>

7 <script>	7 <script>

8 waitForEventAndFail('error');	8 waitForEventAndFail('error');

9	9

10 // Given long enough duration, We should not reach ended playback state.	10 // Given long enough duration, We should not reach ended playback state.

11 waitForEventAndFail('ended');	11 waitForEventAndFail('ended');

12	12

13 // Tuned throttling should not induce player stall or suspended load.	13 // Tuned throttling should not induce player stall or suspended load.

(...skipping 79 matching lines...) Expand 10 before \| Expand all \| Expand 10 after Loading...
93 var mediaFile = findMediaFile('video', 'resources/test');	93 var mediaFile = findMediaFile('video', 'resources/test');

94 var mimeType = mimeTypeForFile(mediaFile);	94 var mimeType = mimeTypeForFile(mediaFile);

95 // Assumes minimum file size selected is > 100 kB.	95 // Assumes minimum file size selected is > 100 kB.

96 // At least 4*maxProgressFiringIntervalInMS is how long we want to stretch t he full	96 // At least 4*maxProgressFiringIntervalInMS is how long we want to stretch t he full

97 // loading, because we perform checks after 3 of these intervals while still	97 // loading, because we perform checks after 3 of these intervals while still

98 // loading. 100 kB over 2.2 seconds is 45 kBps.	98 // loading. 100 kB over 2.2 seconds is 45 kBps.

99 var kBps = 45;	99 var kBps = 45;

100	100

101 video.src = 'video-throttled-load.cgi' + '?name=' + mediaFile + '&throttle=' + kBps + '&type=' + mimeType;	101 video.src = 'video-throttled-load.cgi' + '?name=' + mediaFile + '&throttle=' + kBps + '&type=' + mimeType;

102 </script>	102 </script>

OLD	NEW