third_party/WebKit/LayoutTests/http/tests/media/media-source/mediasource-sourcebufferlist-crash.html - Issue 2015503002: Move TODO(philipj) to TODO(foolip)

Side by Side Diff

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Side by Side Diff: third_party/WebKit/LayoutTests/http/tests/media/media-source/mediasource-sourcebufferlist-crash.html

Issue 2015503002: Move TODO(philipj) to TODO(foolip) (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: rebase Created 4 years, 6 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View unified diff | Download patch

« no previous file with comments | « third_party/WebKit/LayoutTests/http/tests/media/media-source/mediasource-htmlmediaelement-lifetime.html ('k') | third_party/WebKit/LayoutTests/http/tests/media/pdf-served-as-pdf.html » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

OLD	NEW
1 <!DOCTYPE html>	1 <!DOCTYPE html>

2 <html>	2 <html>

3 <head>	3 <head>

4 <script src="/js-test-resources/js-test.js"></script>	4 <script src="/js-test-resources/js-test.js"></script>

5 <!-- TODO(philipj): Convert test to testharness.js. crbug.com/588956	5 <!-- TODO(foolip): Convert test to testharness.js. crbug.com/588956

6 (Please avoid writing new tests using video-test.js) -->	6 (Please avoid writing new tests using video-test.js) -->

7 <script src="/media-resources/video-test.js"></script>	7 <script src="/media-resources/video-test.js"></script>

8 <script type="text/javascript">	8 <script type="text/javascript">

9 function onSourceOpen(e)	9 function onSourceOpen(e)

10 {	10 {

11 consoleWrite("Calling addSourceBuffer()");	11 consoleWrite("Calling addSourceBuffer()");

12 e.target.addSourceBuffer('video/webm;codecs="vp8"');	12 e.target.addSourceBuffer('video/webm;codecs="vp8"');

13	13

14 consoleWrite("Running garbage collector to cleanup the SourceBuf fer reference returned by addSourceBuffer()");	14 consoleWrite("Running garbage collector to cleanup the SourceBuf fer reference returned by addSourceBuffer()");

15 gc();	15 gc();

(...skipping 17 matching lines...) Expand all Loading...
33	33

34 video.src = URL.createObjectURL(mediaSource);	34 video.src = URL.createObjectURL(mediaSource);

35 }	35 }

36 </script>	36 </script>

37 </head>	37 </head>

38 <body onload="main()">	38 <body onload="main()">

39 <video id="v"></video>	39 <video id="v"></video>

40 <p>Verify that we don't crash on close if the MediaSource.sourceBuffers ho lds the last reference to its SourceBuffer objects.</p>	40 <p>Verify that we don't crash on close if the MediaSource.sourceBuffers ho lds the last reference to its SourceBuffer objects.</p>

41 </body>	41 </body>

42 </html>	42 </html>

OLD	NEW