third_party/WebKit/LayoutTests/fast/dom/HTMLTableElement/exceptions.html - Issue 2015503002: Move TODO(philipj) to TODO(foolip)

Side by Side Diff

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Side by Side Diff: third_party/WebKit/LayoutTests/fast/dom/HTMLTableElement/exceptions.html

Issue 2015503002: Move TODO(philipj) to TODO(foolip) (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: rebase Created 4 years, 6 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View unified diff | Download patch

« no previous file with comments | « third_party/WebKit/LayoutTests/compositing/video/video-reflection.html ('k') | third_party/WebKit/LayoutTests/fast/events/media-focus-in-standalone-media-document.html » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

OLD	NEW
1 <!DOCTYPE html>	1 <!DOCTYPE html>

2 <html>	2 <html>

3 <head>	3 <head>

4 <script src="../../../resources/js-test.js"></script>	4 <script src="../../../resources/js-test.js"></script>

5 </head>	5 </head>

6 <body>	6 <body>

7 <script>	7 <script>

8 description("This test should trigger exceptions on HTMLTableElement, an d verify that the messages are reasonably helpful.");	8 description("This test should trigger exceptions on HTMLTableElement, an d verify that the messages are reasonably helpful.");

9	9

10 var t = document.createElement('table');	10 var t = document.createElement('table');

11	11

12 // TODO(philipj): Setting caption/tHead/tFoot to null should not throw	12 // TODO(foolip): Setting caption/tHead/tFoot to null should not throw

13 // an exception, it should just remove the old caption/thead/tfoot.	13 // an exception, it should just remove the old caption/thead/tfoot.

14 shouldThrow("t.caption = null");	14 shouldThrow("t.caption = null");

15 shouldThrow("t.caption = document.body");	15 shouldThrow("t.caption = document.body");

16	16

17 shouldThrow("t.tHead = null");	17 shouldThrow("t.tHead = null");

18 shouldThrow("t.tHead = document.body");	18 shouldThrow("t.tHead = document.body");

19	19

20 shouldThrow("t.tFoot = null");	20 shouldThrow("t.tFoot = null");

21 shouldThrow("t.tFoot = document.body");	21 shouldThrow("t.tFoot = document.body");

22	22

23 shouldThrow("t.insertRow(-2)");	23 shouldThrow("t.insertRow(-2)");

24 shouldThrow("t.insertRow(1)");	24 shouldThrow("t.insertRow(1)");

25	25

26 t.insertRow();	26 t.insertRow();

27	27

28 shouldThrow("t.deleteRow(-2)");	28 shouldThrow("t.deleteRow(-2)");

29 shouldThrow("t.deleteRow(2)");	29 shouldThrow("t.deleteRow(2)");

30 shouldThrow("t.deleteRow()");	30 shouldThrow("t.deleteRow()");

31 </script>	31 </script>

32 </body>	32 </body>

33 </html>	33 </html>

OLD	NEW