Mark the Izenpe log as Disqualified

net/cert/ct_known_logs_static-inc.h

Index: net/cert/ct_known_logs_static-inc.h
diff --git a/net/cert/ct_known_logs_static-inc.h b/net/cert/ct_known_logs_static-inc.h
index 5b348c1462037f4a43e290e80949d5522e2f4ec6..03fc3bfd81193f532f1ebf7e7af9e6bc35fa3c26 100644
--- a/net/cert/ct_known_logs_static-inc.h
+++ b/net/cert/ct_known_logs_static-inc.h
@@ -46,13 +46,6 @@ const CTLogInfo kCTLogList[] = {
      "\x77\x2d\x05\xc2\x40\x7a",
      91, "Google 'Rocketeer' log", "https://ct.googleapis.com/rocketeer/"},
     {"\x30\x59\x30\x13\x06\x07\x2a\x86\x48\xce\x3d\x02\x01\x06\x08\x2a\x86"
-     "\x48\xce\x3d\x03\x01\x07\x03\x42\x00\x04\x27\x64\x39\x0c\x2d\xdc\x50"
-     "\x18\xf8\x21\x00\xa2\x0e\xed\x2c\xea\x3e\x75\xba\x9f\x93\x64\x09\x00"
-     "\x11\xc4\x11\x17\xab\x5c\xcf\x0f\x74\xac\xb5\x97\x90\x93\x00\x5b\xb8"
-     "\xeb\xf7\x27\x3d\xd9\xb2\x0a\x81\x5f\x2f\x0d\x75\x38\x94\x37\x99\x1e"
-     "\xf6\x07\x76\xe0\xee\xbe",
-     91, "Izenpe log", "https://ct.izenpe.com/"},
-    {"\x30\x59\x30\x13\x06\x07\x2a\x86\x48\xce\x3d\x02\x01\x06\x08\x2a\x86"
      "\x48\xce\x3d\x03\x01\x07\x03\x42\x00\x04\x96\xea\xac\x1c\x46\x0c\x1b"
      "\x55\xdc\x0d\xfc\xb5\x94\x27\x46\x57\x42\x70\x3a\x69\x18\xe2\xbf\x3b"
      "\xc4\xdb\xab\xa0\xf4\xb6\x6c\xc0\x53\x3f\x4d\x42\x10\x33\xf0\x58\x97"
@@ -94,26 +87,41 @@ struct DisqualifiedCTLogInfo {
 
   const CTLogInfo log_info;
 
-  // The internal base::Time() serialization of when the log was disqualified.
+  // The offset from the Unix Epoch of when the log was disqualified.
   // SCTs embedded in pre-certificates after this date should not count
   // towards any uniqueness/freshness requirements.
-  const int64_t disqualification_date;
+  const base::TimeDelta disqualification_date;

[eroman, 2016/05/26 00:47:40]

Why the change?

[Ryan Sleevi, 2016/05/26 08:49:50]

Already answered this in the previous message, but it seems to have been missed

1) You rightly raised a concern about FromInternalValue() in the previous CL,
and expressed a desire for something more readable. FromExploded has issues, but
we can at least use the Unix Epoch as a point
2) TimeDelta is now constexpr, so this no longer invokes a static initializer,
therefore it's semantically clearer than int64_t

 };
 
 // The set of all disqualified logs, sorted by |log_id|.
-const DisqualifiedCTLogInfo kDisqualifiedCTLogList[] = {{
-    "\xcd\xb5\x17\x9b\x7f\xc1\xc0\x46\xfe\xea\x31\x13\x6a\x3f\x8f\x00\x2e"
-    "\x61\x82\xfa\xf8\x89\x6f\xec\xc8\xb2\xf5\xb5\xab\x60\x49\x00",
-    {"\x30\x59\x30\x13\x06\x07\x2a\x86\x48\xce\x3d\x02\x01\x06\x08\x2a\x86"
-     "\x48\xce\x3d\x03\x01\x07\x03\x42\x00\x04\x0b\x23\xcb\x85\x62\x98\x61"
-     "\x48\x04\x73\xeb\x54\x5d\xf3\xd0\x07\x8c\x2d\x19\x2d\x8c\x36\xf5\xeb"
-     "\x8f\x01\x42\x0a\x7c\x98\x26\x27\xc1\xb5\xdd\x92\x93\xb0\xae\xf8\x9b"
-     "\x3d\x0c\xd8\x4c\x4e\x1d\xf9\x15\xfb\x47\x68\x7b\xba\x66\xb7\x25\x9c"
-     "\xd0\x4a\xc2\x66\xdb\x48",
-     91, "Certly.IO log", "https://log.certly.io/"},
-    // 2016-04-15 00:00:00 UTC
-    INT64_C(13105152000000000),
-}};
+const DisqualifiedCTLogInfo kDisqualifiedCTLogList[] = {
+    {
+        "\x74\x61\xb4\xa0\x9c\xfb\x3d\x41\xd7\x51\x59\x57\x5b\x2e\x76\x49\xa4"
+        "\x45\xa8\xd2\x77\x09\xb0\xcc\x56\x4a\x64\x82\xb7\xeb\x41\xa3",
+        {"\x30\x59\x30\x13\x06\x07\x2a\x86\x48\xce\x3d\x02\x01\x06\x08\x2a\x86"
+         "\x48\xce\x3d\x03\x01\x07\x03\x42\x00\x04\x27\x64\x39\x0c\x2d\xdc\x50"
+         "\x18\xf8\x21\x00\xa2\x0e\xed\x2c\xea\x3e\x75\xba\x9f\x93\x64\x09\x00"
+         "\x11\xc4\x11\x17\xab\x5c\xcf\x0f\x74\xac\xb5\x97\x90\x93\x00\x5b\xb8"
+         "\xeb\xf7\x27\x3d\xd9\xb2\x0a\x81\x5f\x2f\x0d\x75\x38\x94\x37\x99\x1e"
+         "\xf6\x07\x76\xe0\xee\xbe",
+         91, "Izenpe log", "https://ct.izenpe.com/"},
+        // 2016-05-30 00:00:00 UTC
+        base::TimeDelta::FromSeconds(INT64_C(1464566400)),
+    },
+    {
+        "\xcd\xb5\x17\x9b\x7f\xc1\xc0\x46\xfe\xea\x31\x13\x6a\x3f\x8f\x00\x2e"
+        "\x61\x82\xfa\xf8\x89\x6f\xec\xc8\xb2\xf5\xb5\xab\x60\x49\x00",
+        {"\x30\x59\x30\x13\x06\x07\x2a\x86\x48\xce\x3d\x02\x01\x06\x08\x2a\x86"
+         "\x48\xce\x3d\x03\x01\x07\x03\x42\x00\x04\x0b\x23\xcb\x85\x62\x98\x61"
+         "\x48\x04\x73\xeb\x54\x5d\xf3\xd0\x07\x8c\x2d\x19\x2d\x8c\x36\xf5\xeb"
+         "\x8f\x01\x42\x0a\x7c\x98\x26\x27\xc1\xb5\xdd\x92\x93\xb0\xae\xf8\x9b"
+         "\x3d\x0c\xd8\x4c\x4e\x1d\xf9\x15\xfb\x47\x68\x7b\xba\x66\xb7\x25\x9c"
+         "\xd0\x4a\xc2\x66\xdb\x48",
+         91, "Certly.IO log", "https://log.certly.io/"},
+        // 2016-04-15 00:00:00 UTC
+        base::TimeDelta::FromSeconds(INT64_C(1460678400)),

[eroman, 2016/05/26 00:47:40]

You can drop the INT64_C() now

[Ryan Sleevi, 2016/05/26 08:49:50]

Are you asking me to remove this?

INT64_C is part of stdint, it's part of C++11, and it's part of general portable
code. It would seem you're saying "You don't need to write portable code" -
which, while true, is unclear if you're also saying "You shouldn't write
portable code"

[eroman, 2016/05/26 19:30:16]

Yes, I was asking you to remove it.

Do you really find:
  base::TimeDelta::FromSeconds(INT64_C(1460678400))

To be more readable than:
  base::TimeDelta::FromSeconds(1460678400),

?

+    },
+};
 
 // The list is sorted.
 const char kGoogleLogIDs[][33] = {