Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(941)

Unified Diff: content/browser/bluetooth/bluetooth_metrics.h

Issue 2015463004: bluetooth: Use BluetoothUUID instead of string when sending uuids (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@bluetooth-mojo-request-device
Patch Set: Fix merge conflict Created 4 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: content/browser/bluetooth/bluetooth_metrics.h
diff --git a/content/browser/bluetooth/bluetooth_metrics.h b/content/browser/bluetooth/bluetooth_metrics.h
index d6307947956f8ffd21327dd65d5bf1c66d171f99..9579061a92d0739617ee484946d911121436a9f3 100644
--- a/content/browser/bluetooth/bluetooth_metrics.h
+++ b/content/browser/bluetooth/bluetooth_metrics.h
@@ -139,7 +139,8 @@ enum class UMAGetPrimaryServiceOutcome {
COUNT
};
// Record the service uuid used when calling getPrimaryService.
-void RecordGetPrimaryServiceService(const device::BluetoothUUID& service);
+void RecordGetPrimaryServiceService(
+ const base::Optional<device::BluetoothUUID>& service);
// There should be a call to this function for every call to
// Send(BluetoothMsg_GetPrimaryServiceSuccess) and
// Send(BluetoothMsg_GetPrimaryServiceError).
@@ -179,7 +180,7 @@ void RecordGetCharacteristicsOutcome(
// Records the UUID of the characteristic used when calling getCharacteristic.
void RecordGetCharacteristicsCharacteristic(
blink::mojom::WebBluetoothGATTQueryQuantity quantity,
- const std::string& characteristic);
+ const base::Optional<device::BluetoothUUID>& characteristic);
// GATT Operations Metrics
« no previous file with comments | « content/browser/bluetooth/bluetooth_device_chooser_controller.cc ('k') | content/browser/bluetooth/bluetooth_metrics.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698