content/browser/bluetooth/bluetooth_metrics.h - Issue 2015463004: bluetooth: Use BluetoothUUID instead of string when sending uuids

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: content/browser/bluetooth/bluetooth_metrics.h

Issue 2015463004: bluetooth: Use BluetoothUUID instead of string when sending uuids (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@bluetooth-mojo-request-device

Patch Set: Clean up Created 4 years, 7 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« content/browser/bluetooth/bluetooth_allowed_devices_map_unittest.cc ('K') | « content/browser/bluetooth/bluetooth_device_chooser_controller.cc ('k') | content/browser/bluetooth/bluetooth_metrics.cc » ('j') | device/bluetooth/bluetooth_uuid.h » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: content/browser/bluetooth/bluetooth_metrics.h

diff --git a/content/browser/bluetooth/bluetooth_metrics.h b/content/browser/bluetooth/bluetooth_metrics.h

index d6307947956f8ffd21327dd65d5bf1c66d171f99..9579061a92d0739617ee484946d911121436a9f3 100644

--- a/content/browser/bluetooth/bluetooth_metrics.h

+++ b/content/browser/bluetooth/bluetooth_metrics.h

@@ -139,7 +139,8 @@ enum class UMAGetPrimaryServiceOutcome {

COUNT

};

// Record the service uuid used when calling getPrimaryService.

-void RecordGetPrimaryServiceService(const device::BluetoothUUID& service);

+void RecordGetPrimaryServiceService(

+ const base::Optional<device::BluetoothUUID>& service);

// There should be a call to this function for every call to

// Send(BluetoothMsg_GetPrimaryServiceSuccess) and

// Send(BluetoothMsg_GetPrimaryServiceError).

@@ -179,7 +180,7 @@ void RecordGetCharacteristicsOutcome(

// Records the UUID of the characteristic used when calling getCharacteristic.

void RecordGetCharacteristicsCharacteristic(

blink::mojom::WebBluetoothGATTQueryQuantity quantity,

- const std::string& characteristic);

+ const base::Optional<device::BluetoothUUID>& characteristic);

// GATT Operations Metrics