device/bluetooth/mojo/bluetooth_uuid.typemap - Issue 2015463004: bluetooth: Use BluetoothUUID instead of string when sending uuids

Side by Side Diff: device/bluetooth/mojo/bluetooth_uuid.typemap

Issue 2015463004: bluetooth: Use BluetoothUUID instead of string when sending uuids (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@bluetooth-mojo-request-device

Patch Set: Add header Created 4 years, 7 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View unified diff | Download patch

« device/bluetooth/mojo/bluetooth_uuid.mojom ('K') | « device/bluetooth/mojo/bluetooth_uuid.mojom ('k') | device/bluetooth/mojo/bluetooth_uuid_struct_traits.h » ('j') | device/bluetooth/mojo/bluetooth_uuid_struct_traits.h » ('J')
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

OLD	NEW
(Empty)
	1 # Copyright 2016 The Chromium Authors. All rights reserved.

	2 # Use of this source code is governed by a BSD-style license that can be

	3 # found in the LICENSE file.

	4

	5 mojom = "//device/bluetooth/mojo/bluetooth_uuid.mojom"

	6 public_headers = [ "//device/bluetooth/bluetooth_uuid.h" ]

	7 traits_headers = [ "//device/bluetooth/mojo/bluetooth_uuid_struct_traits.h" ]

	8 deps = [

	9 "//device/bluetooth",

	10 ]

	11 type_mappings = [ "device.mojom.BluetoothUUID=std::unique_ptr<device::BluetoothU UID>" ]
	ortuno 2016/05/26 20:46:13 It would be nice if I could define a different typ It would be nice if I could define a different type that is used for nullable fields e.g.: type_mappings = [ "device.mojom.BluetoothUUID=device::BluetoothUUID" ] type_mappings = [ "device.mojom.BluetoothUUID?=std::unique_ptr<device::BluetoothUUID>" ] Ken Rockot(use gerrit already) 2016/05/26 21:05:07 I don't think we want to force people to do that. Show quoted text On 2016/05/26 at 20:46:13, ortuno wrote: > It would be nice if I could define a different type that is used for nullable fields e.g.: > > type_mappings = [ "device.mojom.BluetoothUUID=device::BluetoothUUID" ] > type_mappings = [ "device.mojom.BluetoothUUID?=std::unique_ptr<device::BluetoothUUID>" ] I don't think we want to force people to do that. I think we should try to establish a general purpose solution for nullable types that we can apply regardless of typemapping. This is an ongoing discussion that we can hopefully resolve soon. As an alternative interim solution for you, would it maybe be cleaner to support an "invalid" state for your device::BluetoothUUID type rather than map to a unique_ptr? ortuno 2016/05/27 14:38:35 Yes. That would be even nicer. Show quoted text On 2016/05/26 at 21:05:07, Ken Rockot wrote: > On 2016/05/26 at 20:46:13, ortuno wrote: > > It would be nice if I could define a different type that is used for nullable fields e.g.: > > > > type_mappings = [ "device.mojom.BluetoothUUID=device::BluetoothUUID" ] > > type_mappings = [ "device.mojom.BluetoothUUID?=std::unique_ptr<device::BluetoothUUID>" ] > > I don't think we want to force people to do that. I think we should try to establish a general purpose solution for nullable types that we can apply regardless of typemapping. This is an ongoing discussion that we can hopefully resolve soon. > Yes. That would be even nicer. Show quoted text > As an alternative interim solution for you, would it maybe be cleaner to support an "invalid" state for your device::BluetoothUUID type rather than map to a unique_ptr? BluetoothUUID already has an "invalid" state but we use that for validation. See bluetooth_uuid_struct_traits.h Ken Rockot(use gerrit already) 2016/05/27 14:57:42 Doh, right. Show quoted text On 2016/05/27 at 14:38:35, ortuno wrote: > On 2016/05/26 at 21:05:07, Ken Rockot wrote: > > On 2016/05/26 at 20:46:13, ortuno wrote: > > > It would be nice if I could define a different type that is used for nullable fields e.g.: > > > > > > type_mappings = [ "device.mojom.BluetoothUUID=device::BluetoothUUID" ] > > > type_mappings = [ "device.mojom.BluetoothUUID?=std::unique_ptr<device::BluetoothUUID>" ] > > > > I don't think we want to force people to do that. I think we should try to establish a general purpose solution for nullable types that we can apply regardless of typemapping. This is an ongoing discussion that we can hopefully resolve soon. > > > > Yes. That would be even nicer. > > > As an alternative interim solution for you, would it maybe be cleaner to support an "invalid" state for your device::BluetoothUUID type rather than map to a unique_ptr? > > BluetoothUUID already has an "invalid" state but we use that for validation. See bluetooth_uuid_struct_traits.h Doh, right.
OLD	NEW