Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(9)

Unified Diff: content/common/android/media_metadata_android.cc

Issue 2015433003: Implement MediaMetadata artwork in content (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: fixed nits Created 4 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « content/browser/media/session/media_session.cc ('k') | content/common/media/media_metadata_sanitizer.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: content/common/android/media_metadata_android.cc
diff --git a/content/common/android/media_metadata_android.cc b/content/common/android/media_metadata_android.cc
index 0bd1563175891fc221764f984e5f1b048c62ab0f..4e2228bf1115b4ce9dbafd581c564a1dd32e7a1a 100644
--- a/content/common/android/media_metadata_android.cc
+++ b/content/common/android/media_metadata_android.cc
@@ -4,12 +4,30 @@
#include "content/common/android/media_metadata_android.h"
+#include <string>
+#include <vector>
+
+#include "base/android/jni_array.h"
#include "base/android/jni_string.h"
#include "content/public/common/media_metadata.h"
#include "jni/MediaMetadata_jni.h"
namespace content {
+namespace {
+
+std::vector<int> GetFlattenedSizeArray(const std::vector<gfx::Size>& sizes) {
+ std::vector<int> flattened_array;
+ flattened_array.reserve(2 * sizes.size());
+ for (const auto& size : sizes) {
+ flattened_array.push_back(size.width());
+ flattened_array.push_back(size.height());
+ }
+ return flattened_array;
+}
+
+} // anonymous namespace
+
// static
base::android::ScopedJavaLocalRef<jobject>
MediaMetadataAndroid::CreateJavaObject(
@@ -21,8 +39,26 @@ MediaMetadataAndroid::CreateJavaObject(
ScopedJavaLocalRef<jstring> j_album(
base::android::ConvertUTF16ToJavaString(env, metadata.album));
- return Java_MediaMetadata_create(
+ ScopedJavaLocalRef<jobject> j_metadata = Java_MediaMetadata_create(
env, j_title.obj(), j_artist.obj(), j_album.obj());
+
+ for (const auto& artwork : metadata.artwork) {
+ std::string src = artwork.src.spec();
+ base::string16 type = artwork.type.is_null() ?
+ base::string16() : artwork.type.string();
+ ScopedJavaLocalRef<jstring> j_src(
+ base::android::ConvertUTF8ToJavaString(env, src));
+ ScopedJavaLocalRef<jstring> j_type(
+ base::android::ConvertUTF16ToJavaString(env, type));
+ ScopedJavaLocalRef<jintArray> j_sizes(
+ base::android::ToJavaIntArray(
+ env, GetFlattenedSizeArray(artwork.sizes)));
+
+ Java_MediaMetadata_createAndAddArtwork(
+ env, j_metadata.obj(), j_src.obj(), j_type.obj(), j_sizes.obj());
+ }
+
+ return j_metadata;
}
// static
« no previous file with comments | « content/browser/media/session/media_session.cc ('k') | content/common/media/media_metadata_sanitizer.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698