Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(6)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 201543002: Remove a unused method and fix some styles according to the style guide. (Closed)

Created:
6 years, 9 months ago by Sungmann Cho
Modified:
6 years, 9 months ago
Reviewers:
Yaron
CC:
chromium-reviews, erikwright+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Visibility:
Public.

Description

Remove a unused method and fix some styles according to the style guide. Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=257921

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+13 lines, -25 lines) Patch
M base/android/java/src/org/chromium/base/library_loader/LibraryLoader.java View 7 chunks +13 lines, -25 lines 0 comments Download

Messages

Total messages: 21 (0 generated)
Sungmann Cho
PTAL :)
6 years, 9 months ago (2014-03-17 19:28:08 UTC) #1
Yaron
lgtm
6 years, 9 months ago (2014-03-18 18:03:40 UTC) #2
Sungmann Cho
The CQ bit was checked by sungmann.cho@navercorp.com
6 years, 9 months ago (2014-03-18 18:39:03 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/sungmann.cho@navercorp.com/201543002/1
6 years, 9 months ago (2014-03-18 18:57:47 UTC) #4
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
6 years, 9 months ago (2014-03-18 19:29:43 UTC) #5
commit-bot: I haz the power
Try jobs failed on following builders: tryserver.chromium on linux_chromium_clang_dbg
6 years, 9 months ago (2014-03-18 19:29:44 UTC) #6
Sungmann Cho
The CQ bit was checked by sungmann.cho@navercorp.com
6 years, 9 months ago (2014-03-18 21:54:49 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/sungmann.cho@navercorp.com/201543002/1
6 years, 9 months ago (2014-03-18 21:57:14 UTC) #8
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
6 years, 9 months ago (2014-03-18 22:18:52 UTC) #9
commit-bot: I haz the power
Try jobs failed on following builders: tryserver.chromium on linux_chromium_clang_dbg
6 years, 9 months ago (2014-03-18 22:18:53 UTC) #10
Sungmann Cho
The CQ bit was checked by sungmann.cho@navercorp.com
6 years, 9 months ago (2014-03-18 22:28:37 UTC) #11
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/sungmann.cho@navercorp.com/201543002/1
6 years, 9 months ago (2014-03-18 22:32:14 UTC) #12
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
6 years, 9 months ago (2014-03-18 22:45:39 UTC) #13
commit-bot: I haz the power
Try jobs failed on following builders: tryserver.chromium on linux_chromium_clang_dbg
6 years, 9 months ago (2014-03-18 22:45:39 UTC) #14
Sungmann Cho
The CQ bit was checked by sungmann.cho@navercorp.com
6 years, 9 months ago (2014-03-18 23:46:25 UTC) #15
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/sungmann.cho@navercorp.com/201543002/1
6 years, 9 months ago (2014-03-18 23:52:13 UTC) #16
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
6 years, 9 months ago (2014-03-19 00:00:55 UTC) #17
commit-bot: I haz the power
Try jobs failed on following builders: tryserver.chromium on linux_chromium_clang_dbg
6 years, 9 months ago (2014-03-19 00:00:56 UTC) #18
Sungmann Cho
The CQ bit was checked by sungmann.cho@navercorp.com
6 years, 9 months ago (2014-03-19 00:46:32 UTC) #19
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/sungmann.cho@navercorp.com/201543002/1
6 years, 9 months ago (2014-03-19 00:48:42 UTC) #20
commit-bot: I haz the power
6 years, 9 months ago (2014-03-19 11:13:46 UTC) #21
Message was sent while issue was closed. 
Change committed as 257921

Powered by Google App Engine
This is Rietveld 408576698