Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(8081)

Unified Diff: chrome/browser/ui/webui/chromeos/login/oobe_ui.cc

Issue 2015413002: Enable the PIN keyboard on the lockscreen. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@lkgr
Patch Set: Address comments Created 4 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/ui/webui/chromeos/login/oobe_ui.cc
diff --git a/chrome/browser/ui/webui/chromeos/login/oobe_ui.cc b/chrome/browser/ui/webui/chromeos/login/oobe_ui.cc
index 264f528bcb51d3bb54485c4373fd33d94afdc1a7..8fdde8afa25b57afc7b52c44b874a63b0b67b946 100644
--- a/chrome/browser/ui/webui/chromeos/login/oobe_ui.cc
+++ b/chrome/browser/ui/webui/chromeos/login/oobe_ui.cc
@@ -111,10 +111,6 @@ const char kEnrollmentHTMLPath[] = "enrollment.html";
const char kEnrollmentCSSPath[] = "enrollment.css";
const char kEnrollmentJSPath[] = "enrollment.js";
-// Shared parameter with JS that enables or disables the PIN screen. This needs
-// to stay synchronized with the JS definition.
-const char kShowPinKey[] = "showPin";
-
// Creates a WebUIDataSource for chrome://oobe
content::WebUIDataSource* CreateOobeUIDataSource(
const base::DictionaryValue& localized_strings,
@@ -140,9 +136,6 @@ content::WebUIDataSource* CreateOobeUIDataSource(
IDR_CUSTOM_ELEMENTS_PIN_KEYBOARD_HTML);
source->AddResourcePath(kCustomElementsPinKeyboardJSPath,
IDR_CUSTOM_ELEMENTS_PIN_KEYBOARD_JS);
-
- // TODO(jdufault): Dynamically show pin when it is enabled.
- source->AddBoolean(kShowPinKey, false);
} else {
source->SetDefaultResource(IDR_LOGIN_HTML);
source->AddResourcePath(kLoginJSPath, IDR_LOGIN_JS);
« no previous file with comments | « chrome/browser/resources/chromeos/login/lock.js ('k') | chrome/browser/ui/webui/chromeos/login/signin_screen_handler.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698