chrome/test/data/extensions/platform_apps/web_view/scrollable_embedder_and_guest/guest.js - Issue 2015373002: Fix webview crash on attempt to scroll.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/test/data/extensions/platform_apps/web_view/scrollable_embedder_and_guest/guest.js

Issue 2015373002: Fix webview crash on attempt to scroll. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: fixed content_tests (handle case when view is not available), added expected event into Fling test … Created 4 years, 6 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/test/data/extensions/platform_apps/web_view/scrollable_embedder_and_guest/guest.html ('k') | chrome/test/data/extensions/platform_apps/web_view/scrollable_embedder_and_guest/main.html » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/test/data/extensions/platform_apps/web_view/scrollable_embedder_and_guest/guest.js

diff --git a/chrome/test/data/extensions/platform_apps/web_view/scrollable_embedder_and_guest/guest.js b/chrome/test/data/extensions/platform_apps/web_view/scrollable_embedder_and_guest/guest.js

index 6821f6ec042f224dd21e51079c600ff0d2962db8..d1fc9251e34b1d63f5824a766845d300b4579e5f 100644

--- a/chrome/test/data/extensions/platform_apps/web_view/scrollable_embedder_and_guest/guest.js

+++ b/chrome/test/data/extensions/platform_apps/web_view/scrollable_embedder_and_guest/guest.js

@@ -20,7 +20,7 @@ window.onAppCommand = function(command) {

LOG('guest::onAppCommand: ' + command);

switch (command) {

case 'set_overflow_hidden':

- document.body.style.overflow = 'hidden';

+ document.getElementById('root').style.overflow = 'hidden';

sendMessageToEmbedder('overflow_is_hidden');

break;

};