Show related nodes as expandable sub-tree unless there is only one and no attribute value

Show related nodes as expandable sub-tree unless there is only one and no attribute value

BUG=470311
Committed: https://crrev.com/475bda36f7624035cc7112e6ac7989ca52e722e6
Cr-Commit-Position: refs/heads/master@{#396945}

[aboxhall, 2016-05-27 18:32:53]

aboxhall@chromium.org changed reviewers:
+ dgozman@chromium.org

[aboxhall, 2016-05-27 18:32:54]

An even more minor tweak.

See https://bugs.chromium.org/p/chromium/issues/detail?id=470311#c20 for
screenshot.

[dgozman, 2016-05-31 19:27:23]

lgtm

https://codereview.chromium.org/2015303002/diff/1/third_party/WebKit/Source/d...
File
third_party/WebKit/Source/devtools/front_end/accessibility/AccessibilityNodeView.js
(right):

https://codereview.chromium.org/2015303002/diff/1/third_party/WebKit/Source/d...
third_party/WebKit/Source/devtools/front_end/accessibility/AccessibilityNodeView.js:224:
if (!value.value || value.relatedNodes.length === 0)
Shouldn't this be && instead of || ?

https://codereview.chromium.org/2015303002/diff/1/third_party/WebKit/Source/d...
third_party/WebKit/Source/devtools/front_end/accessibility/AccessibilityNodeView.js:266:
if (value.relatedNodes.length === 1 && !("value" in value)) {
!value.value

[aboxhall, 2016-05-31 21:26:03]

The CQ bit was checked by aboxhall@chromium.org

[aboxhall, 2016-05-31 21:26:04]

The patchset sent to the CQ was uploaded after l-g-t-m from dgozman@chromium.org
Link to the patchset: https://codereview.chromium.org/2015303002/#ps20001
(title: "review comments")

[commit-bot: I haz the power, 2016-05-31 21:26:53]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/2015303002/20001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/2015303002/20001

[commit-bot: I haz the power, 2016-05-31 22:04:23]

Committed patchset #2 (id:20001)

[commit-bot: I haz the power, 2016-05-31 22:05:18]

Description was changed from

==========
Show related nodes as expandable sub-tree unless there is only one and no
attribute value

BUG=470311
==========

to

==========
Show related nodes as expandable sub-tree unless there is only one and no
attribute value

BUG=470311

Committed: https://crrev.com/475bda36f7624035cc7112e6ac7989ca52e722e6
Cr-Commit-Position: refs/heads/master@{#396945}
==========

[commit-bot: I haz the power, 2016-05-31 22:05:19]

Patchset 2 (id:??) landed as
https://crrev.com/475bda36f7624035cc7112e6ac7989ca52e722e6
Cr-Commit-Position: refs/heads/master@{#396945}

[aboxhall, 2016-06-01 17:55:11]

Oops, forgot to send comments :|

https://codereview.chromium.org/2015303002/diff/1/third_party/WebKit/Source/d...
File
third_party/WebKit/Source/devtools/front_end/accessibility/AccessibilityNodeView.js
(right):

https://codereview.chromium.org/2015303002/diff/1/third_party/WebKit/Source/d...
third_party/WebKit/Source/devtools/front_end/accessibility/AccessibilityNodeView.js:224:
if (!value.value || value.relatedNodes.length === 0)
On 2016/05/31 19:27:23, dgozman wrote:
> Shouldn't this be && instead of || ?

I probably don't need to check the length of relatedNodes here at all, actually.
We'll only want to call createSimpleValueElement if value.value exists,
regardless of the length of relatedNodes.

https://codereview.chromium.org/2015303002/diff/1/third_party/WebKit/Source/d...
third_party/WebKit/Source/devtools/front_end/accessibility/AccessibilityNodeView.js:266:
if (value.relatedNodes.length === 1 && !("value" in value)) {
On 2016/05/31 19:27:23, dgozman wrote:
> !value.value

Done.