Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(64)

Issue 201523002: Replace manual pointer arithmetic with WTF:Vector in Gradient::shader() (Closed)

Created:
6 years, 9 months ago by jbroman
Modified:
6 years, 9 months ago
CC:
blink-reviews, jamesr, krit, dsinclair, jbroman, danakj, Rik, pdr., rwlbuis
Base URL:
https://chromium.googlesource.com/chromium/blink.git@master
Visibility:
Public.

Description

Replace manual pointer arithmetic with WTF::Vector in Gradient::shader() It's more idiomatic to use a vector for a dynamically-sized array; it also provides a convenient opportunity to use inline capacity in the common case where a gradient has a small number of stops. BUG= Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=169686

Patch Set 1 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+9 lines, -9 lines) Patch
M Source/platform/graphics/Gradient.cpp View 5 chunks +9 lines, -9 lines 0 comments Download

Messages

Total messages: 10 (0 generated)
jbroman
While looking at WebCore::Gradient, I noticed a FIXME complaining about pointer arithmetic. I looked at ...
6 years, 9 months ago (2014-03-20 18:40:06 UTC) #1
Stephen Chennney
LBTM. I think it's worth doing to make life a bit cleaner. Given the small ...
6 years, 9 months ago (2014-03-20 19:03:55 UTC) #2
Stephen Chennney
On 2014/03/20 19:03:55, Stephen Chenney wrote: > LBTM. I think it's worth doing to make ...
6 years, 9 months ago (2014-03-20 19:04:22 UTC) #3
jbroman
The CQ bit was checked by jbroman@chromium.org
6 years, 9 months ago (2014-03-20 19:11:20 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/jbroman@chromium.org/201523002/20001
6 years, 9 months ago (2014-03-20 19:11:21 UTC) #5
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
6 years, 9 months ago (2014-03-20 19:13:56 UTC) #6
commit-bot: I haz the power
Try jobs failed on following builders: tryserver.blink on win_blink_compile_dbg
6 years, 9 months ago (2014-03-20 19:13:56 UTC) #7
jbroman
The CQ bit was checked by jbroman@chromium.org
6 years, 9 months ago (2014-03-20 19:27:15 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/jbroman@chromium.org/201523002/20001
6 years, 9 months ago (2014-03-20 19:27:21 UTC) #9
commit-bot: I haz the power
6 years, 9 months ago (2014-03-20 20:00:03 UTC) #10
Message was sent while issue was closed.
Change committed as 169686

Powered by Google App Engine
This is Rietveld 408576698