Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(581)

Issue 2015213002: Revert of Add OpenGL support to Linux viewer (Closed)

Created:
4 years, 6 months ago by kjlubick
Modified:
4 years, 6 months ago
CC:
reviews_skia.org
Base URL:
https://skia.googlesource.com/skia.git@master
Target Ref:
refs/heads/master
Project:
skia
Visibility:
Public.

Description

Revert of Add OpenGL support to Linux viewer (patchset #5 id:80001 of https://codereview.chromium.org/2011473003/ ) Reason for revert: Build-Ubuntu-GCC-Arm7-Debug-Android_Vulkan is broken and this patch prevents the revert of the culprit Original issue's description: > Add OpenGL support to Linux viewer > > Also adds a command line option (--vulkan) to choose between > Vulkan and OpenGL. > GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2011473003 > > Committed: https://skia.googlesource.com/skia/+/10b3815a11c39b154ec7b74a2af43e019b50d48c TBR=egdaniel@google.com,bsalomon@google.com,brianosman@google.com,jvanverth@google.com # Skipping CQ checks because original CL landed less than 1 days ago. NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true Committed: https://skia.googlesource.com/skia/+/0248bfd8d25575cdfe6f45b74d5b485839b805a9

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+36 lines, -143 lines) Patch
M tools/viewer/Viewer.cpp View 5 chunks +3 lines, -10 lines 0 comments Download
M tools/viewer/sk_app/VulkanWindowContext.cpp View 1 chunk +0 lines, -1 line 0 comments Download
M tools/viewer/sk_app/Window.cpp View 1 chunk +0 lines, -1 line 0 comments Download
M tools/viewer/sk_app/unix/VulkanWindowContext_unix.cpp View 2 chunks +2 lines, -3 lines 0 comments Download
M tools/viewer/sk_app/unix/Window_unix.h View 4 chunks +9 lines, -20 lines 0 comments Download
M tools/viewer/sk_app/unix/Window_unix.cpp View 7 chunks +22 lines, -108 lines 0 comments Download

Messages

Total messages: 4 (1 generated)
kjlubick
Created Revert of Add OpenGL support to Linux viewer
4 years, 6 months ago (2016-05-27 13:20:02 UTC) #1
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/2015213002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/2015213002/1
4 years, 6 months ago (2016-05-27 13:20:05 UTC) #2
commit-bot: I haz the power
4 years, 6 months ago (2016-05-27 13:20:13 UTC) #4
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://skia.googlesource.com/skia/+/0248bfd8d25575cdfe6f45b74d5b485839b805a9

Powered by Google App Engine
This is Rietveld 408576698