Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(106)

Issue 2015193002: Also add comments requested by review, and some more. (Closed)

Created:
4 years, 6 months ago by Lasse Reichstein Nielsen
Modified:
4 years, 6 months ago
Reviewers:
floitsch, eernst
CC:
reviews_dartlang.org, floitsch
Base URL:
https://github.com/dart-lang/sdk.git@master
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Also add comments requested by review, and some more. Also exclude more environments from running the test, restricting it to *only* the stand-alone VM and the analyzer. Committed: https://github.com/dart-lang/sdk/commit/7009677096b7f43cfcf5e0b2441eb841072e31bb

Patch Set 1 #

Total comments: 1
Unified diffs Side-by-side diffs Delta from patch set Stats (+28 lines, -4 lines) Patch
M tests/standalone/packages_file_test.dart View 7 chunks +25 lines, -3 lines 1 comment Download
M tests/standalone/standalone.status View 2 chunks +3 lines, -1 line 0 comments Download

Messages

Total messages: 9 (4 generated)
Lasse Reichstein Nielsen
4 years, 6 months ago (2016-05-27 10:55:59 UTC) #3
Lasse Reichstein Nielsen
LGTM for the status file change.
4 years, 6 months ago (2016-05-27 11:06:38 UTC) #4
Lasse Reichstein Nielsen
Committed patchset #1 (id:1) manually as 7009677096b7f43cfcf5e0b2441eb841072e31bb (presubmit successful).
4 years, 6 months ago (2016-05-27 11:07:44 UTC) #6
eernst
lgtm
4 years, 6 months ago (2016-05-27 13:31:31 UTC) #7
floitsch
4 years, 6 months ago (2016-05-27 14:11:19 UTC) #9
Message was sent while issue was closed.
Lgtm.
Thanks.

https://codereview.chromium.org/2015193002/diff/1/tests/standalone/packages_f...
File tests/standalone/packages_file_test.dart (right):

https://codereview.chromium.org/2015193002/diff/1/tests/standalone/packages_f...
tests/standalone/packages_file_test.dart:19: // With no specified resolutiuon
and no implicit .packages or packages/
Resolution

Powered by Google App Engine
This is Rietveld 408576698