xfa/fxjse/include/fxjse.h - Issue 2015143005: Workaround dubious casting between CXFA_Object and void* in FXJSE

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: xfa/fxjse/include/fxjse.h

Issue 2015143005: Workaround dubious casting between CXFA_Object and void* in FXJSE (Closed) Base URL: https://pdfium.googlesource.com/pdfium.git@master

Patch Set: Revert typecheck, actually fix code. Created 4 years, 7 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: xfa/fxjse/include/fxjse.h

diff --git a/xfa/fxjse/include/fxjse.h b/xfa/fxjse/include/fxjse.h

index d2d0bd9014cf4cb7df674a50b4857795ee4ef105..e278935657e780edd9bd28d1b93721295c8122cd 100644

--- a/xfa/fxjse/include/fxjse.h

+++ b/xfa/fxjse/include/fxjse.h

@@ -72,8 +72,8 @@ void FXJSE_Runtime_Release(v8::Isolate* pIsolate, bool bOwnedRuntime);

CFXJSE_Context* FXJSE_Context_Create(

v8::Isolate* pIsolate,

- const FXJSE_CLASS_DESCRIPTOR* lpGlobalClass = nullptr,

- void* lpGlobalObject = nullptr);

+ const FXJSE_CLASS_DESCRIPTOR* lpGlobalClass,

+ void* lpGlobalObject);

void FXJSE_Context_Release(CFXJSE_Context* pContext);

CFXJSE_Value* FXJSE_Context_GetGlobalObject(CFXJSE_Context* pContext);

« no previous file with comments | « xfa/fxjse/context.cpp ('k') | xfa/fxjse/util_inline.h » ('j') | no next file with comments »