Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(301)

Issue 2015133003: Decompress credits page on iOS (Closed)

Created:
4 years, 7 months ago by Jackie Quinn
Modified:
4 years, 6 months ago
CC:
chromium-reviews, sdefresne+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Decompress credits page on iOS Brotli compression as applied to the about credits HTML file in https://codereview.chromium.org/1951363002/, but not decompressed in the iOS about credits WebUI code. BUG=614859 Committed: https://crrev.com/32eda8ce8613f976725af63c57b31c74f4297ebb Cr-Commit-Position: refs/heads/master@{#396909}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+22 lines, -2 lines) Patch
M ios/chrome/browser/BUILD.gn View 1 chunk +1 line, -0 lines 0 comments Download
M ios/chrome/browser/DEPS View 1 chunk +1 line, -0 lines 0 comments Download
M ios/chrome/browser/ui/webui/about_ui.cc View 2 chunks +19 lines, -2 lines 0 comments Download
M ios/chrome/ios_chrome.gyp View 1 chunk +1 line, -0 lines 0 comments Download

Messages

Total messages: 14 (5 generated)
Jackie Quinn
4 years, 7 months ago (2016-05-27 00:48:43 UTC) #2
Kunihiko Sakamoto
+smaier non-owner lgtm.
4 years, 7 months ago (2016-05-27 01:14:06 UTC) #3
smaier
On 2016/05/27 01:14:06, Kunihiko Sakamoto wrote: > +smaier > > non-owner lgtm. lgtm
4 years, 6 months ago (2016-05-27 12:58:13 UTC) #4
sdefresne
lgtm if the bots are happy
4 years, 6 months ago (2016-05-28 13:07:22 UTC) #5
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/2015133003/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/2015133003/1
4 years, 6 months ago (2016-05-31 17:25:20 UTC) #7
commit-bot: I haz the power
Dry run: This issue passed the CQ dry run.
4 years, 6 months ago (2016-05-31 18:54:35 UTC) #9
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/2015133003/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/2015133003/1
4 years, 6 months ago (2016-05-31 20:02:55 UTC) #11
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 6 months ago (2016-05-31 20:08:38 UTC) #12
commit-bot: I haz the power
4 years, 6 months ago (2016-05-31 20:45:02 UTC) #14
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/32eda8ce8613f976725af63c57b31c74f4297ebb
Cr-Commit-Position: refs/heads/master@{#396909}

Powered by Google App Engine
This is Rietveld 408576698