Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(53)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 2015133002: Move memory dumper from public/platform/ to platform/ (Closed)

Created:
4 years, 6 months ago by bashi
Modified:
4 years, 6 months ago
Reviewers:
haraken, esprehn
CC:
Mads Ager (chromium), ajuma+watch_chromium.org, blink-reviews, blink-reviews-api_chromium.org, blink-reviews-platform-graphics_chromium.org, Rik, chromium-reviews, danakj+watch_chromium.org, dglazkov+blink, dshwang, drott+blinkwatch_chromium.org, krit, f(malita), gavinp+loader_chromium.org, Nate Chapin, jbroman, Justin Novosad, kouhei+heap_chromium.org, loading-reviews+fetch_chromium.org, oilpan-reviews, pdr+graphicswatchlist_chromium.org, rwlbuis, Stephen Chennney, tyoshino+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Move memory dumper from public/platform/ to platform/ These are no longer Blink APIs. BUG=605822 Committed: https://crrev.com/35ef483c57a5b4e47a3c60943751ed7b61a071fc Cr-Commit-Position: refs/heads/master@{#396422}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+27 lines, -203 lines) Patch
M third_party/WebKit/Source/core/fetch/Resource.h View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/core/fetch/Resource.cpp View 1 chunk +0 lines, -1 line 0 comments Download
M third_party/WebKit/Source/core/fetch/ScriptResource.cpp View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/platform/MemoryCacheDumpProvider.h View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/platform/PurgeableVector.cpp View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/platform/SharedBuffer.cpp View 1 chunk +1 line, -1 line 0 comments Download
A + third_party/WebKit/Source/platform/WebMemoryAllocatorDump.h View 1 chunk +2 lines, -2 lines 0 comments Download
A + third_party/WebKit/Source/platform/WebMemoryAllocatorDump.cpp View 1 chunk +1 line, -1 line 0 comments Download
A + third_party/WebKit/Source/platform/WebProcessMemoryDump.h View 1 chunk +3 lines, -3 lines 0 comments Download
A + third_party/WebKit/Source/platform/WebProcessMemoryDump.cpp View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/platform/blink_platform.gypi View 2 chunks +4 lines, -2 lines 0 comments Download
D third_party/WebKit/Source/platform/exported/WebMemoryAllocatorDump.cpp View 1 chunk +0 lines, -13 lines 0 comments Download
D third_party/WebKit/Source/platform/exported/WebProcessMemoryDump.cpp View 1 chunk +0 lines, -13 lines 0 comments Download
M third_party/WebKit/Source/platform/fonts/FontCache.cpp View 2 chunks +2 lines, -2 lines 0 comments Download
M third_party/WebKit/Source/platform/heap/BlinkGCMemoryDumpProvider.cpp View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/platform/heap/Heap.cpp View 2 chunks +2 lines, -2 lines 0 comments Download
M third_party/WebKit/Source/platform/heap/HeapPage.cpp View 2 chunks +2 lines, -2 lines 0 comments Download
M third_party/WebKit/Source/platform/heap/ThreadState.cpp View 2 chunks +2 lines, -2 lines 0 comments Download
M third_party/WebKit/Source/platform/web_memory_allocator_dump_impl.h View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/platform/web_process_memory_dump_impl.h View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/public/blink_headers.gypi View 2 chunks +0 lines, -2 lines 0 comments Download
D third_party/WebKit/public/platform/WebMemoryAllocatorDump.h View 1 chunk +0 lines, -43 lines 0 comments Download
D third_party/WebKit/public/platform/WebProcessMemoryDump.h View 1 chunk +0 lines, -106 lines 0 comments Download

Messages

Total messages: 9 (3 generated)
bashi
PTAL?
4 years, 6 months ago (2016-05-27 01:40:05 UTC) #2
haraken
LGTM
4 years, 6 months ago (2016-05-27 02:30:56 UTC) #3
esprehn
Lgtm awesome!
4 years, 6 months ago (2016-05-27 04:04:10 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/2015133002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/2015133002/1
4 years, 6 months ago (2016-05-27 07:17:34 UTC) #6
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 6 months ago (2016-05-27 07:49:49 UTC) #7
commit-bot: I haz the power
4 years, 6 months ago (2016-05-27 07:52:18 UTC) #9
Message was sent while issue was closed. 
Patchset 1 (id:??) landed as
https://crrev.com/35ef483c57a5b4e47a3c60943751ed7b61a071fc
Cr-Commit-Position: refs/heads/master@{#396422}

Powered by Google App Engine
This is Rietveld 408576698