Added r396173 to .git-blame-ignore-revs.

Added r396173 to .git-blame-ignore-revs.

Large mechanical rename change; should be ignored in git hyper-blame.

BUG=none

Committed: https://crrev.com/a9fc453fc4a576f1714c9f9fb33115681ef28fc4
Cr-Commit-Position: refs/heads/master@{#398231}

[Matt Giuca, 2016-05-27 00:35:58]

mgiuca@chromium.org changed reviewers:
+ thakis@chromium.org

[Matt Giuca, 2016-05-27 00:35:59]

See: https://codereview.chromium.org/1998723002/

[Matt Giuca, 2016-06-06 03:15:50]

Ni Nico, friendly ping?

[Nico, 2016-06-06 13:18:21]

lgtm if you want to add it. "semi-manually" in the cl description sounds like
something we may or may not want to hide...

[Matt Giuca, 2016-06-07 04:27:35]

On 2016/06/06 13:18:21, Nico wrote:
> lgtm if you want to add it. "semi-manually" in the cl description sounds like
> something we may or may not want to hide...

Hmm, not sure what "semi-manually" means there but it was several thousands of
lines that looked like basically a simple substitution. Seems quite appropriate
for this.

[Matt Giuca, 2016-06-07 04:27:39]

The CQ bit was checked by mgiuca@chromium.org

[commit-bot: I haz the power, 2016-06-07 04:27:56]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/2015123002/1

[commit-bot: I haz the power, 2016-06-07 05:19:37]

Committed patchset #1 (id:1)

[commit-bot: I haz the power, 2016-06-07 05:21:24]

Description was changed from

==========
Added r396173 to .git-blame-ignore-revs.

Large mechanical rename change; should be ignored in git hyper-blame.

BUG=none
==========

to

==========
Added r396173 to .git-blame-ignore-revs.

Large mechanical rename change; should be ignored in git hyper-blame.

BUG=none

Committed: https://crrev.com/a9fc453fc4a576f1714c9f9fb33115681ef28fc4
Cr-Commit-Position: refs/heads/master@{#398231}
==========

[commit-bot: I haz the power, 2016-06-07 05:21:25]

Patchset 1 (id:??) landed as
https://crrev.com/a9fc453fc4a576f1714c9f9fb33115681ef28fc4
Cr-Commit-Position: refs/heads/master@{#398231}

[kylechar, 2016-06-07 13:21:29]

On 2016/06/07 05:21:25, commit-bot: I haz the power wrote:
> Patchset 1 (id:??) landed as
> https://crrev.com/a9fc453fc4a576f1714c9f9fb33115681ef28fc4
> Cr-Commit-Position: refs/heads/master@{#398231}

Just to clear up what semi-manually meant, I couldn't find any way to do a
simple substitution (sed/perl/etc) for forward declared classes changing
namespaces.

For example, there were a couple files with forward declarations like this:

namespace gfx {
class Size;
class GLSurface;
}

namespace gl {
class GLImage;
}

that had to become this:

namespace gfx {
class Size;
}

namespace gl {
class GLImage;
class GLSurface;
}

I ended up grepping for forward declarations of symbols that changed namespace
but doing the substitution by hand (it was just easier than writing a
complicated script).

[Matt Giuca, 2016-06-08 00:26:45]

On 2016/06/07 13:21:29, kylechar wrote:
> On 2016/06/07 05:21:25, commit-bot: I haz the power wrote:
> > Patchset 1 (id:??) landed as
> > https://crrev.com/a9fc453fc4a576f1714c9f9fb33115681ef28fc4
> > Cr-Commit-Position: refs/heads/master@{#398231}
> 
> Just to clear up what semi-manually meant, I couldn't find any way to do a
> simple substitution (sed/perl/etc) for forward declared classes changing
> namespaces.
> 
> For example, there were a couple files with forward declarations like this:
> 
> namespace gfx {
> class Size;
> class GLSurface;
> }
> 
> namespace gl {
> class GLImage;
> }
> 
> that had to become this:
> 
> namespace gfx {
> class Size;
> }
> 
> namespace gl {
> class GLImage;
> class GLSurface;
> }
> 
> I ended up grepping for forward declarations of symbols that changed namespace
> but doing the substitution by hand (it was just easier than writing a
> complicated script).

Thanks for the explanation.