Correctly update scroll offset animations in response to scroll anchoring

third_party/WebKit/Source/platform/scroll/ScrollAnimatorCompositorCoordinator.h

Index: third_party/WebKit/Source/platform/scroll/ScrollAnimatorCompositorCoordinator.h
diff --git a/third_party/WebKit/Source/platform/scroll/ScrollAnimatorCompositorCoordinator.h b/third_party/WebKit/Source/platform/scroll/ScrollAnimatorCompositorCoordinator.h
index c13767e21d3c0eca3e534d6ac0bc45f053707ce7..1fbd01c3005ecf024f9290f830c6cb3a632665fb 100644
--- a/third_party/WebKit/Source/platform/scroll/ScrollAnimatorCompositorCoordinator.h
+++ b/third_party/WebKit/Source/platform/scroll/ScrollAnimatorCompositorCoordinator.h
@@ -13,6 +13,7 @@
 #include "platform/animation/CompositorAnimationPlayerClient.h"
 #include "platform/geometry/FloatPoint.h"
 #include "platform/heap/Handle.h"
+#include "platform/scroll/ScrollTypes.h"
 #include "wtf/Allocator.h"
 #include "wtf/Noncopyable.h"
 #include "wtf/OwnPtr.h"
@@ -34,8 +35,6 @@ public:
     void dispose();
     String runStateAsText() const;
 
-    void adjustImplOnlyScrollOffsetAnimation(const FloatSize& adjustment);
-
     virtual bool hasRunningAnimation() const { return false; }
 
     virtual void resetAnimationState();
@@ -44,6 +43,9 @@ public:
     // and continues it on the main thread. This should only be called when in
     // DocumentLifecycle::LifecycleState::CompositingClean state.
     virtual void takeOverCompositorAnimation();
+    // Updates the scroll position of the animator's ScrollableArea by
+    // adjustment and update the target of an ongoing scroll offset animation.
+    virtual void adjustAnimationAndSetScrollPosition(IntSize adjustment, ScrollType);
     virtual void updateCompositorAnimations();
 
     virtual ScrollableArea* getScrollableArea() const = 0;
@@ -57,14 +59,17 @@ public:
 protected:
     explicit ScrollAnimatorCompositorCoordinator();
 
-    FloatSize implOnlyAnimationAdjustmentForTesting() { return m_implOnlyAnimationAdjustment; }
+    void adjustImplOnlyScrollOffsetAnimation(const IntSize& adjustment);
+    IntSize implOnlyAnimationAdjustmentForTesting() { return m_implOnlyAnimationAdjustment; }
 
+    void resetAnimationIds();
     bool addAnimation(PassOwnPtr<CompositorAnimation>);
     void removeAnimation();
     virtual void abortAnimation();
 
     FloatPoint compositorOffsetFromBlinkOffset(FloatPoint);
     FloatPoint blinkOffsetFromCompositorOffset(FloatPoint);
+    IntSize compositorSizeFromBlinkSize(IntSize);

[skobes, 2016/05/27 17:58:30]

A size is a size, it's only scroll offset that has two different concepts.  Add
an overload of compositorOffsetFromBlinkOffset if necessary (but per my other
comment I don't even think you need that).

[ymalik, 2016/05/27 20:03:11]

Removed this.

 
     void compositorAnimationFinished(int groupId);
     // Returns true if the compositor player was attached to a new layer.
@@ -128,6 +133,11 @@ protected:
         // running animation is aborted and an animation to the new target
         // from the current position is started.
         WaitingToCancelOnCompositorButNewScroll,
+
+        // Running an animation on the compositor but an adjustment to the
+        // scroll position was made on the main thread and the animation must
+        // be updated.
+        RunningOnCompositorButNeedsAdjustment,
     };
 
     OwnPtr<CompositorAnimationPlayer> m_compositorPlayer;
@@ -138,7 +148,7 @@ protected:
 
     // An adjustment to the scroll offset on the main thread that may affect
     // impl-only scroll offset animations.
-    FloatSize m_implOnlyAnimationAdjustment;
+    IntSize m_implOnlyAnimationAdjustment;
 
     // If set to true, sends a cc::ScrollOffsetAnimationUpdate to cc which will
     // abort the impl-only scroll offset animation and continue it on main