Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(318)

Unified Diff: runtime/vm/object_dbc_test.cc

Issue 2015113002: DBC: Collect type feedback for fastpath smi ops (Closed) Base URL: git@github.com:dart-lang/sdk.git@master
Patch Set: Add comment Created 4 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « runtime/vm/intermediate_language.cc ('k') | runtime/vm/simulator_dbc.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: runtime/vm/object_dbc_test.cc
diff --git a/runtime/vm/object_dbc_test.cc b/runtime/vm/object_dbc_test.cc
index 464350d17a73ddbff4a1b3032312a7dff0f8f745..ecb1fa08647a4ea4f27b5efaa291e9545e471c30 100644
--- a/runtime/vm/object_dbc_test.cc
+++ b/runtime/vm/object_dbc_test.cc
@@ -16,14 +16,12 @@ namespace dart {
// Generate a simple dart code sequence.
// This is used to test Code and Instruction object creation.
+// For other architectures, this sequence does do an increment, hence the name.
+// On DBC, we don't do an increment because generating an instance call here
+// would be too complex.
void GenerateIncrement(Assembler* assembler) {
__ Frame(1);
- __ LoadConstant(0, Smi::Handle(Smi::New(0)));
- __ PushConstant(Smi::Handle(Smi::New(1)));
- __ Push(0);
- __ AddTOS();
- __ Trap();
- __ PopLocal(0);
+ __ LoadConstant(0, Smi::Handle(Smi::New(1)));
__ Return(0);
}
« no previous file with comments | « runtime/vm/intermediate_language.cc ('k') | runtime/vm/simulator_dbc.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698