runtime/vm/object_dbc_test.cc - Issue 2015113002: DBC: Collect type feedback for fastpath smi ops

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: runtime/vm/object_dbc_test.cc

Issue 2015113002: DBC: Collect type feedback for fastpath smi ops (Closed) Base URL: git@github.com:dart-lang/sdk.git@master

Patch Set: Make instance calls following fast pathed ops mandatory Created 4 years, 7 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: runtime/vm/object_dbc_test.cc

diff --git a/runtime/vm/object_dbc_test.cc b/runtime/vm/object_dbc_test.cc

index 464350d17a73ddbff4a1b3032312a7dff0f8f745..f69e354a42f846e9dc379f501391df0032455cbe 100644

--- a/runtime/vm/object_dbc_test.cc

+++ b/runtime/vm/object_dbc_test.cc

@@ -18,12 +18,7 @@ namespace dart {

// This is used to test Code and Instruction object creation.

void GenerateIncrement(Assembler* assembler) {

Vyacheslav Egorov (Google) 2016/06/01 22:41:10 Add a comment that we don't want to generate incre

zra 2016/06/03 16:08:57 Done.

__ Frame(1);

- __ LoadConstant(0, Smi::Handle(Smi::New(0)));

- __ PushConstant(Smi::Handle(Smi::New(1)));

- __ Push(0);

- __ AddTOS();

- __ Trap();

- __ PopLocal(0);

+ __ LoadConstant(0, Smi::Handle(Smi::New(1)));

__ Return(0);

}