mash: Convert shelf to wm::WmWindow types, part 1

mash: Convert shelf to wm::WmWindow types, part 1

Shelf and its dependencies need to use wm::WmWindow so they can run both in
classic ash and mash (with combined desktop_wm / ash_sysui).

* Eliminate ash::RootWindowController use in ShelfWidget and StatusAreaWidget
* Convert aura::Window use in shelf and status header files to wm::WmWindow
* Eliminate unnecessary ShelfWidget::container_window_

No functional changes.

BUG=615155
TEST=existing ash_unittests

Committed: https://crrev.com/6500ad13c690b28b2ea3cf10ff5a4b3f37d4115e
Cr-Commit-Position: refs/heads/master@{#396405}

[James Cook, 2016-05-26 22:16:55]

jamescook@chromium.org changed reviewers:
+ sky@chromium.org

[James Cook, 2016-05-26 22:16:56]

sky, please take a look. It's a small step, but I gotta start somewhere. :-)

https://codereview.chromium.org/2015043002/diff/20001/ash/shelf/shelf_widget.cc
File ash/shelf/shelf_widget.cc (right):

https://codereview.chromium.org/2015043002/diff/20001/ash/shelf/shelf_widget....
ash/shelf/shelf_widget.cc:733: void ShelfWidget::PostCreateShelf() {
This method is unfortunate, but I need it to preserve the ordering of observer
notifications between the RootWindowController and ShelfLayoutManager.

(The shelf code is a mess. I have a diagram on my whiteboard if you're morbidly
curious.)

[sky, 2016-05-26 22:44:06]

LGTM

[James Cook, 2016-05-27 05:03:37]

The CQ bit was checked by jamescook@chromium.org

[commit-bot: I haz the power, 2016-05-27 05:04:01]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/2015043002/20001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/2015043002/20001

[commit-bot: I haz the power, 2016-05-27 06:16:05]

Committed patchset #2 (id:20001)

[commit-bot: I haz the power, 2016-05-27 06:17:07]

Description was changed from

==========
mash: Convert shelf to wm::WmWindow types, part 1

Shelf and its dependencies need to use wm::WmWindow so they can run both in
classic ash and mash (with combined desktop_wm / ash_sysui).

* Eliminate ash::RootWindowController use in ShelfWidget and StatusAreaWidget
* Convert aura::Window use in shelf and status header files to wm::WmWindow
* Eliminate unnecessary ShelfWidget::container_window_

No functional changes.

BUG=615155
TEST=existing ash_unittests
==========

to

==========
mash: Convert shelf to wm::WmWindow types, part 1

Shelf and its dependencies need to use wm::WmWindow so they can run both in
classic ash and mash (with combined desktop_wm / ash_sysui).

* Eliminate ash::RootWindowController use in ShelfWidget and StatusAreaWidget
* Convert aura::Window use in shelf and status header files to wm::WmWindow
* Eliminate unnecessary ShelfWidget::container_window_

No functional changes.

BUG=615155
TEST=existing ash_unittests

Committed: https://crrev.com/6500ad13c690b28b2ea3cf10ff5a4b3f37d4115e
Cr-Commit-Position: refs/heads/master@{#396405}
==========

[commit-bot: I haz the power, 2016-05-27 06:17:08]

Patchset 2 (id:??) landed as
https://crrev.com/6500ad13c690b28b2ea3cf10ff5a4b3f37d4115e
Cr-Commit-Position: refs/heads/master@{#396405}