Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(332)

Unified Diff: third_party/WebKit/Source/core/frame/LocalFrame.h

Issue 2015003002: Disallow local/remote checks on subclasses of Frame, FrameOwner and DOMWindow. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: pure virtual Created 4 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: third_party/WebKit/Source/core/frame/LocalFrame.h
diff --git a/third_party/WebKit/Source/core/frame/LocalFrame.h b/third_party/WebKit/Source/core/frame/LocalFrame.h
index 13138662ecb92f2fdfaaf9a595154ed9b1ea2586..2e8d5735469ca7e5e96efa5604dde3135d0a1b97 100644
--- a/third_party/WebKit/Source/core/frame/LocalFrame.h
+++ b/third_party/WebKit/Source/core/frame/LocalFrame.h
@@ -90,7 +90,6 @@ public:
// Frame overrides:
~LocalFrame() override;
DECLARE_VIRTUAL_TRACE();
- bool isLocalFrame() const override { return true; }
DOMWindow* domWindow() const override;
WindowProxy* windowProxy(DOMWrapperWorld&) override;
void navigate(Document& originDocument, const KURL&, bool replaceCurrentItem, UserGestureStatus) override;
@@ -189,6 +188,10 @@ private:
// Internal Frame helper overrides:
WindowProxyManager* getWindowProxyManager() const override;
+ // Intentionally private to prevent redundant checks when the type is
+ // already LocalFrame.
+ bool isLocalFrame() const override { return true; }
+ bool isRemoteFrame() const override { return false; }
String localLayerTreeAsText(unsigned flags) const;
« no previous file with comments | « third_party/WebKit/Source/core/frame/LocalDOMWindow.h ('k') | third_party/WebKit/Source/core/frame/RemoteDOMWindow.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698