Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(436)

Unified Diff: third_party/WebKit/Source/core/frame/LocalDOMWindow.h

Issue 2015003002: Disallow local/remote checks on subclasses of Frame, FrameOwner and DOMWindow. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: pure virtual Created 4 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: third_party/WebKit/Source/core/frame/LocalDOMWindow.h
diff --git a/third_party/WebKit/Source/core/frame/LocalDOMWindow.h b/third_party/WebKit/Source/core/frame/LocalDOMWindow.h
index a6e4d289c3a98002bdf09a4307cb81a757a0e85e..aec06af7756700d3d41d47d7f1ed8280ff0c738e 100644
--- a/third_party/WebKit/Source/core/frame/LocalDOMWindow.h
+++ b/third_party/WebKit/Source/core/frame/LocalDOMWindow.h
@@ -86,7 +86,6 @@ public:
LocalDOMWindow* toLocalDOMWindow() override;
// DOMWindow overrides:
- bool isLocalDOMWindow() const override { return true; }
LocalFrame* frame() const override;
Screen* screen() const override;
History* history() const override;
@@ -211,6 +210,11 @@ protected:
private:
class WindowFrameObserver;
+ // Intentionally private to prevent redundant checks when the type is
+ // already LocalDOMWindow.
+ bool isLocalDOMWindow() const override { return true; }
+ bool isRemoteDOMWindow() const override { return false; }
+
explicit LocalDOMWindow(LocalFrame&);
void dispose();
« no previous file with comments | « third_party/WebKit/Source/core/frame/FrameOwner.h ('k') | third_party/WebKit/Source/core/frame/LocalFrame.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698