third_party/WebKit/Source/modules/notifications/NotificationPermissionClient.cpp - Issue 2015003002: Disallow local/remote checks on subclasses of Frame, FrameOwner and DOMWindow.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/modules/notifications/NotificationPermissionClient.cpp

Issue 2015003002: Disallow local/remote checks on subclasses of Frame, FrameOwner and DOMWindow. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Created 4 years, 7 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« third_party/WebKit/Source/core/frame/LocalFrame.h ('K') | « third_party/WebKit/Source/modules/audio_output_devices/AudioOutputDeviceClient.cpp ('k') | third_party/WebKit/Source/web/RemoteFrameOwner.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: third_party/WebKit/Source/modules/notifications/NotificationPermissionClient.cpp

diff --git a/third_party/WebKit/Source/modules/notifications/NotificationPermissionClient.cpp b/third_party/WebKit/Source/modules/notifications/NotificationPermissionClient.cpp

index 8bc91abcef4beeb6b95fcdeb1f163aad3c96f1f1..745485db42575d5c2451e5622a0c931adcda932b 100644

--- a/third_party/WebKit/Source/modules/notifications/NotificationPermissionClient.cpp

+++ b/third_party/WebKit/Source/modules/notifications/NotificationPermissionClient.cpp

@@ -21,7 +21,7 @@ NotificationPermissionClient* NotificationPermissionClient::from(ExecutionContex

return nullptr;

const Document* document = toDocument(context);

- if (!document->frame() || !document->frame()->isLocalFrame())

+ if (!document->frame())

return nullptr;

return static_cast<NotificationPermissionClient*>(Supplement<LocalFrame>::from(document->frame(), supplementName()));