third_party/WebKit/Source/core/frame/LocalDOMWindow.h - Issue 2015003002: Disallow local/remote checks on subclasses of Frame, FrameOwner and DOMWindow.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/core/frame/LocalDOMWindow.h

Issue 2015003002: Disallow local/remote checks on subclasses of Frame, FrameOwner and DOMWindow. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Created 4 years, 7 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « third_party/WebKit/Source/core/frame/FrameOwner.h ('k') | third_party/WebKit/Source/core/frame/LocalFrame.h » ('j') | third_party/WebKit/Source/core/frame/LocalFrame.h » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: third_party/WebKit/Source/core/frame/LocalDOMWindow.h

diff --git a/third_party/WebKit/Source/core/frame/LocalDOMWindow.h b/third_party/WebKit/Source/core/frame/LocalDOMWindow.h

index a6e4d289c3a98002bdf09a4307cb81a757a0e85e..6fec6f0fc34b8d1af9dd4ebe882e5560eca7b176 100644

--- a/third_party/WebKit/Source/core/frame/LocalDOMWindow.h

+++ b/third_party/WebKit/Source/core/frame/LocalDOMWindow.h

@@ -86,7 +86,6 @@ public:

LocalDOMWindow* toLocalDOMWindow() override;

// DOMWindow overrides:

- bool isLocalDOMWindow() const override { return true; }

LocalFrame* frame() const override;

Screen* screen() const override;

History* history() const override;

@@ -211,6 +210,11 @@ protected:

private:

class WindowFrameObserver;

+ // Intentionally private to prevent redundant checks when the type is

+ // already LocalDOMWindow.

+ bool isLocalDOMWindow() const override { return true; }

+ using DOMWindow::isRemoteDOMWindow;

esprehn 2016/05/26 20:36:45 can we just write return false here?

dcheng 2016/05/26 20:45:32 Done.

explicit LocalDOMWindow(LocalFrame&);

void dispose();