Chromium Code Reviews
|
|
Chromium Code Reviews
Issue
2014993002:
toy to play with antialias raytracing (Closed)
Descriptiontoy to play with antialias raytracing
Here's the ray tracer I wrote.
I've commented out the calls to experimental
stroking -- enough of it remains working
to help visualize what you've been talking
to me about.
R=reed@google.com
GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2014993002
Committed: https://skia.googlesource.com/skia/+/64022c1ed2174fb499027f902c25be60ef7c3737
Patch Set 1 #Patch Set 2 : fix linux errors #Patch Set 3 : fix linux warnings #Patch Set 4 : one last linux warning #
Messages
Total messages: 24 (12 generated)
Description was changed from ========== toy to play with antialias raytracing Here's the ray tracer I wrote. I've commented out the calls to experimental stroking -- enough of it remains working to help visualize what you've been talking to me about. R=reed@google.com ========== to ========== toy to play with antialias raytracing Here's the ray tracer I wrote. I've commented out the calls to experimental stroking -- enough of it remains working to help visualize what you've been talking to me about. R=reed@google.com GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2014993002 ==========
lgtm
The CQ bit was checked by reed@google.com
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/2014993002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/2014993002/1
The CQ bit was unchecked by commit-bot@chromium.org
Try jobs failed on following builders: Test-Ubuntu-GCC-GCE-CPU-AVX2-x86_64-Debug-Trybot on client.skia (JOB_FAILED, http://build.chromium.org/p/client.skia/builders/Test-Ubuntu-GCC-GCE-CPU-AVX2...) Test-Ubuntu-GCC-GCE-CPU-AVX2-x86_64-Release-Shared-Trybot on client.skia (JOB_FAILED, http://build.chromium.org/p/client.skia/builders/Test-Ubuntu-GCC-GCE-CPU-AVX2...)
The CQ bit was checked by caryclark@google.com to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/2014993002/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/2014993002/20001
The CQ bit was unchecked by commit-bot@chromium.org
Dry run: Try jobs failed on following builders: Build-Ubuntu-GCC-x86_64-Release-Trybot on client.skia.compile (JOB_FAILED, http://build.chromium.org/p/client.skia.compile/builders/Build-Ubuntu-GCC-x86...)
The CQ bit was checked by caryclark@google.com to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/2014993002/40001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/2014993002/40001
The CQ bit was unchecked by commit-bot@chromium.org
Dry run: Try jobs failed on following builders: Build-Ubuntu-GCC-x86_64-Release-Trybot on client.skia.compile (JOB_FAILED, http://build.chromium.org/p/client.skia.compile/builders/Build-Ubuntu-GCC-x86...)
The CQ bit was checked by caryclark@google.com to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/2014993002/60001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/2014993002/60001
The CQ bit was unchecked by commit-bot@chromium.org
Dry run: This issue passed the CQ dry run.
The CQ bit was checked by caryclark@google.com
The patchset sent to the CQ was uploaded after l-g-t-m from reed@google.com Link to the patchset: https://codereview.chromium.org/2014993002/#ps60001 (title: "one last linux warning")
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/2014993002/60001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/2014993002/60001
Message was sent while issue was closed.
Description was changed from ========== toy to play with antialias raytracing Here's the ray tracer I wrote. I've commented out the calls to experimental stroking -- enough of it remains working to help visualize what you've been talking to me about. R=reed@google.com GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2014993002 ========== to ========== toy to play with antialias raytracing Here's the ray tracer I wrote. I've commented out the calls to experimental stroking -- enough of it remains working to help visualize what you've been talking to me about. R=reed@google.com GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2014993002 Committed: https://skia.googlesource.com/skia/+/64022c1ed2174fb499027f902c25be60ef7c3737 ==========
Message was sent while issue was closed.
Committed patchset #4 (id:60001) as https://skia.googlesource.com/skia/+/64022c1ed2174fb499027f902c25be60ef7c3737 |
||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||
