Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(307)

Issue 2014983003: [Android] Build changes needed for Robolectric 3.0. (Closed)

Created:
4 years, 6 months ago by mikecase (-- gone --)
Modified:
4 years, 6 months ago
Reviewers:
jbudorick, agrieve
CC:
chromium-reviews, jbudorick+watch_chromium.org, mikecase+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

[Android] Build changes needed for Robolectric 3.0. Robolectric uses javac annotation processors when building. This means it will need to pass some "-processor RobolectricProcessor" to javac as well as some "-Akey=value" args Additionally, since this processor is run by javac, Robolectric can't be compiled using the interface.jars. This is why I am adding an enable_interface_jars_javac option for GN. Finally, Robolectric uses the Java services functionality. I will need to add some configs to the META-INF/services/ dir in the Robolectric jars for this to work correctly. This is the purpose of the --provider-configurations option I am adding. BUG= Committed: https://crrev.com/14569c856b4cd3a362f89a3b913f744b9a210732 Cr-Commit-Position: refs/heads/master@{#397262}

Patch Set 1 #

Patch Set 2 : #

Total comments: 1

Patch Set 3 : Fixed agrieves nit and mispelling. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+76 lines, -6 lines) Patch
M build/android/gyp/jar.py View 4 chunks +16 lines, -3 lines 0 comments Download
M build/android/gyp/javac.py View 1 3 chunks +26 lines, -2 lines 0 comments Download
M build/config/android/internal_rules.gni View 1 2 4 chunks +34 lines, -1 line 0 comments Download

Messages

Total messages: 12 (6 generated)
mikecase (-- gone --)
These build changes/additions are what I need to build Robolectric.
4 years, 6 months ago (2016-05-27 17:01:49 UTC) #2
mikecase (-- gone --)
4 years, 6 months ago (2016-06-01 16:35:46 UTC) #4
agrieve
lgtm https://codereview.chromium.org/2014983003/diff/20001/build/config/android/internal_rules.gni File build/config/android/internal_rules.gni (right): https://codereview.chromium.org/2014983003/diff/20001/build/config/android/internal_rules.gni#newcode1518 build/config/android/internal_rules.gni:1518: _enable_iterface_jars_javac = false nit: _enable_iterface_jars_javac = _processors == ...
4 years, 6 months ago (2016-06-01 16:51:43 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/2014983003/40001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/2014983003/40001
4 years, 6 months ago (2016-06-01 19:32:39 UTC) #9
commit-bot: I haz the power
Committed patchset #3 (id:40001)
4 years, 6 months ago (2016-06-01 21:58:41 UTC) #10
commit-bot: I haz the power
4 years, 6 months ago (2016-06-01 22:05:41 UTC) #12
Message was sent while issue was closed.
Patchset 3 (id:??) landed as
https://crrev.com/14569c856b4cd3a362f89a3b913f744b9a210732
Cr-Commit-Position: refs/heads/master@{#397262}

Powered by Google App Engine
This is Rietveld 408576698