Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(114)

Issue 2014983002: Remove unused SkPictureGpuAnalyzer::analyze() (Closed)

Created:
4 years, 7 months ago by f(malita)
Modified:
4 years, 6 months ago
Reviewers:
mtklein, reed1
CC:
reviews_skia.org
Base URL:
https://chromium.googlesource.com/skia.git@master
Target Ref:
refs/heads/master
Project:
skia
Visibility:
Public.

Description

Patch Set 1 #

Patch Set 2 : fix test #

Unified diffs Side-by-side diffs Delta from patch set Stats (+3 lines, -6 lines) Patch
M include/core/SkPictureAnalyzer.h View 1 chunk +0 lines, -3 lines 0 comments Download
M src/core/SkPictureAnalyzer.cpp View 1 chunk +1 line, -1 line 0 comments Download
M tests/PictureTest.cpp View 1 2 chunks +2 lines, -2 lines 0 comments Download

Messages

Total messages: 18 (8 generated)
f(malita)
I’ma sit on this for a while, just in case https://crrev.com/c64bd21780da13051846ae45b54a1e6c6bf6ac52 gets reverted.
4 years, 7 months ago (2016-05-26 19:33:30 UTC) #2
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/2014983002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/2014983002/1
4 years, 7 months ago (2016-05-26 19:33:58 UTC) #4
mtklein
lgtm
4 years, 7 months ago (2016-05-26 19:34:16 UTC) #5
reed1
api lgtm
4 years, 7 months ago (2016-05-26 19:36:22 UTC) #6
commit-bot: I haz the power
Dry run: Try jobs failed on following builders: Test-Ubuntu-GCC-GCE-CPU-AVX2-x86_64-Release-Shared-Trybot on client.skia (JOB_FAILED, http://build.chromium.org/p/client.skia/builders/Test-Ubuntu-GCC-GCE-CPU-AVX2-x86_64-Release-Shared-Trybot/builds/8711)
4 years, 7 months ago (2016-05-26 19:36:48 UTC) #8
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/2014983002/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/2014983002/20001
4 years, 7 months ago (2016-05-26 19:39:47 UTC) #10
commit-bot: I haz the power
Dry run: This issue passed the CQ dry run.
4 years, 7 months ago (2016-05-26 20:10:20 UTC) #12
commit-bot: I haz the power
Dry run: None
4 years, 7 months ago (2016-05-26 20:10:28 UTC) #13
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/2014983002/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/2014983002/20001
4 years, 6 months ago (2016-05-31 13:17:48 UTC) #16
commit-bot: I haz the power
4 years, 6 months ago (2016-05-31 13:33:01 UTC) #18
Message was sent while issue was closed.
Committed patchset #2 (id:20001) as
https://skia.googlesource.com/skia/+/019db3fe885848913645e2dda62c84744ad5ee65

Powered by Google App Engine
This is Rietveld 408576698