DescriptionRevert of Reland: MediaCaptureFromElement: add support for audio captureStream(). (patchset #3 id:40001 of https://codereview.chromium.org/2003963003/ )
Reason for revert:
https://build.chromium.org/p/chromium.webkit/builders/WebKit%20Win10/builds/10592
crashed test.
(I wonder why that wasn't hit by CQ?)
Original issue's description:
> Reland: MediaCaptureFromElement: add support for audio captureStream().
>
> The original CL got reverted due to flaky failures in
> LayoutTests on bots, due to independent (racy)
> initialization of the WebAudioSourceProviderImpl
> and HTMLAudioElementCapturerSource. This extra
> patch decouples both by making TeeFilter
> independently initializable.
>
> Original description --------------------------------------------------
>
> MediaCaptureFromElement: add support for audio captureStream().
>
> This CL extends support for capturing the audio part of
> a <video> or <audio> tags ( "capture" here means creating
> a MediaStream out of the HTMLElement)
>
> It introduces an HtmlAudioCapturerSource is-a AudioCapturerSource
> wrapped into an ExternalMediaStreamAudioSource to produce data
> towards the audio track.
>
> HtmlAudioCapturerSource also plugs into the
> WebMediaPlayer's WebAudioSourceProviderImpl to get
> a copy of the audio being rendered.
>
> Unit tests are added, and the existing LayouTests
> revamped (and split into several files for clarity).
>
> BUG=569976, 575492
> TEST= run chromium with
> --enable-blink-features=MediaCaptureFromVideo
> against e.g.
> https://rawgit.com/Miguelao/demos/master/videoelementcapture.html
> ---------------------------------------------------------------------
>
> TBR=haraken@chromium.org, avi@chromium.org, esprehn@chromium.org, miu@chromium.org
> (reviewers whose reviewed code hasn't changed from the original
> https://codereview.chromium.org/1599533003/)
>
> Committed: https://crrev.com/6d69edab7acf4582c14ba7799dfda168395f26a2
> Cr-Commit-Position: refs/heads/master@{#396200}
TBR=dalecurtis@chromium.org,stgao@chromium.org
# Skipping CQ checks because original CL landed less than 1 days ago.
NOPRESUBMIT=true
NOTREECHECKS=true
NOTRY=true
BUG=569976, 575492
Committed: https://crrev.com/ec5079ff2beac76ee90d9d201f7856213cd0f350
Cr-Commit-Position: refs/heads/master@{#396249}
Patch Set 1 #Messages
Total messages: 6 (2 generated)
|