Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(312)

Issue 2014963002: Revert of Reland: MediaCaptureFromElement: add support for audio captureStream(). (Closed)

Created:
4 years, 6 months ago by mcasas
Modified:
4 years, 6 months ago
Reviewers:
stgao, DaleCurtis
CC:
blink-reviews, blink-reviews-api_chromium.org, chromium-reviews, darin-cc_chromium.org, dglazkov+blink, emircan+watch+capturefromdom_chromium.org, feature-media-reviews_chromium.org, haraken, jam, mcasas+watch+vc_chromium.org, mcasas+watch+capturefromdom_chromium.org, miu+watch_chromium.org, mkwst+moarreviews-renderer_chromium.org, mlamouri+watch-content_chromium.org, posciak+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Revert of Reland: MediaCaptureFromElement: add support for audio captureStream(). (patchset #3 id:40001 of https://codereview.chromium.org/2003963003/ ) Reason for revert: https://build.chromium.org/p/chromium.webkit/builders/WebKit%20Win10/builds/10592 crashed test. (I wonder why that wasn't hit by CQ?) Original issue's description: > Reland: MediaCaptureFromElement: add support for audio captureStream(). > > The original CL got reverted due to flaky failures in > LayoutTests on bots, due to independent (racy) > initialization of the WebAudioSourceProviderImpl > and HTMLAudioElementCapturerSource. This extra > patch decouples both by making TeeFilter > independently initializable. > > Original description -------------------------------------------------- > > MediaCaptureFromElement: add support for audio captureStream(). > > This CL extends support for capturing the audio part of > a <video> or <audio> tags ( "capture" here means creating > a MediaStream out of the HTMLElement) > > It introduces an HtmlAudioCapturerSource is-a AudioCapturerSource > wrapped into an ExternalMediaStreamAudioSource to produce data > towards the audio track. > > HtmlAudioCapturerSource also plugs into the > WebMediaPlayer's WebAudioSourceProviderImpl to get > a copy of the audio being rendered. > > Unit tests are added, and the existing LayouTests > revamped (and split into several files for clarity). > > BUG=569976, 575492 > TEST= run chromium with > --enable-blink-features=MediaCaptureFromVideo > against e.g. > https://rawgit.com/Miguelao/demos/master/videoelementcapture.html > --------------------------------------------------------------------- > > TBR=haraken@chromium.org, avi@chromium.org, esprehn@chromium.org, miu@chromium.org > (reviewers whose reviewed code hasn't changed from the original > https://codereview.chromium.org/1599533003/) > > Committed: https://crrev.com/6d69edab7acf4582c14ba7799dfda168395f26a2 > Cr-Commit-Position: refs/heads/master@{#396200} TBR=dalecurtis@chromium.org,stgao@chromium.org # Skipping CQ checks because original CL landed less than 1 days ago. NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=569976, 575492 Committed: https://crrev.com/ec5079ff2beac76ee90d9d201f7856213cd0f350 Cr-Commit-Position: refs/heads/master@{#396249}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+83 lines, -479 lines) Patch
M content/content_renderer.gypi View 1 chunk +0 lines, -2 lines 0 comments Download
M content/content_tests.gypi View 1 chunk +0 lines, -1 line 0 comments Download
D content/renderer/media/html_audio_element_capturer_source.h View 1 chunk +0 lines, -63 lines 0 comments Download
D content/renderer/media/html_audio_element_capturer_source.cc View 1 chunk +0 lines, -89 lines 0 comments Download
D content/renderer/media/html_audio_element_capturer_source_unittest.cc View 1 chunk +0 lines, -154 lines 0 comments Download
M content/renderer/renderer_blink_platform_impl.h View 1 chunk +0 lines, -3 lines 0 comments Download
M content/renderer/renderer_blink_platform_impl.cc View 3 chunks +0 lines, -29 lines 0 comments Download
M content/test/BUILD.gn View 1 chunk +0 lines, -1 line 0 comments Download
M media/blink/webaudiosourceprovider_impl.h View 2 chunks +3 lines, -3 lines 0 comments Download
M media/blink/webaudiosourceprovider_impl.cc View 9 chunks +32 lines, -41 lines 0 comments Download
D third_party/WebKit/LayoutTests/fast/mediacapturefromelement/HTMLMediaElementCapture-EME-content.html View 1 chunk +0 lines, -28 lines 0 comments Download
D third_party/WebKit/LayoutTests/fast/mediacapturefromelement/HTMLMediaElementCapture-capture.html View 1 chunk +0 lines, -35 lines 0 comments Download
M third_party/WebKit/LayoutTests/fast/mediacapturefromelement/HTMLMediaElementCapture-creation.html View 2 chunks +40 lines, -22 lines 0 comments Download
M third_party/WebKit/Source/modules/mediacapturefromelement/HTMLMediaElementCapture.cpp View 2 chunks +7 lines, -6 lines 0 comments Download
M third_party/WebKit/public/platform/Platform.h View 1 chunk +1 line, -2 lines 0 comments Download

Messages

Total messages: 6 (2 generated)
mcasas
Created Revert of Reland: MediaCaptureFromElement: add support for audio captureStream().
4 years, 6 months ago (2016-05-26 19:10:46 UTC) #1
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/2014963002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/2014963002/1
4 years, 6 months ago (2016-05-26 19:11:24 UTC) #2
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 6 months ago (2016-05-26 19:12:09 UTC) #4
commit-bot: I haz the power
4 years, 6 months ago (2016-05-26 19:13:27 UTC) #6
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/ec5079ff2beac76ee90d9d201f7856213cd0f350
Cr-Commit-Position: refs/heads/master@{#396249}

Powered by Google App Engine
This is Rietveld 408576698